From: Todd Zullinger <tmz@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: "Randall S. Becker" <rsbecker@nexbridge.com>,
Jeff King <peff@peff.net>, 'Junio C Hamano' <gitster@pobox.com>,
git@vger.kernel.org,
'Linux Kernel' <linux-kernel@vger.kernel.org>,
git-packagers@googlegroups.com
Subject: Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)
Date: Fri, 8 Feb 2019 15:11:29 -0500 [thread overview]
Message-ID: <20190208201128.GD30548@zaya.teonanacatl.net> (raw)
In-Reply-To: <20190208111002.GU10587@szeder.dev>
SZEDER Gábor wrote:
> On Fri, Feb 08, 2019 at 05:48:27AM -0500, Randall S. Becker wrote:
>> We have a few new breakages on the NonStop port in 2.21.0-rc0. The first is in t5403, as below:
[...]
>> The post-checkout hook is:
>> #!/usr/local/bin/bash
>> echo "$@" >$GIT_DIR/post-checkout.args
>>
>> This looks like it is a "bash thing" and $GIT_DIR might have to be in quotes, and is not be specific to the platform. If I replace
>>
>> echo "$@" >$GIT_DIR/post-checkout.args
>>
>> with
>>
>> echo "$@" >"$GIT_DIR/post-checkout.args"
>>
>> The test passes.
>
> Wow, this is the second time this "redirection to a filename with
> spaces under Bash" issue pops up today, see the other one here:
>
> https://public-inbox.org/git/20190208031746.22683-2-tmz@pobox.com/T/#u
Indeed, I was surprised to see another one today.
It made me wonder how I had missed it in my own testing.
This one requires SHELL_PATH to be bash, while I only set
TEST_SHELL_PATH to bash for the improved -x tracing in the
fedora builds.
I ran the tests again with SHELL_PATH as bash on fedora and
this was the only failure I saw (other than the one from my
earlier message, that is).
--
Todd
next prev parent reply other threads:[~2019-02-08 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 10:48 [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) Randall S. Becker
2019-02-08 10:55 ` Johannes Schindelin
2019-02-08 10:58 ` Randall S. Becker
2019-02-08 11:10 ` SZEDER Gábor
2019-02-08 11:36 ` Randall S. Becker
2019-02-08 20:11 ` Todd Zullinger [this message]
2019-02-08 20:30 ` SZEDER Gábor
2019-02-09 6:48 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208201128.GD30548@zaya.teonanacatl.net \
--to=tmz@pobox.com \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).