From: Todd Zullinger <tmz@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: "Randall S. Becker" <rsbecker@nexbridge.com>,
Jeff King <peff@peff.net>, 'Junio C Hamano' <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)
Date: Sat, 9 Feb 2019 01:48:21 -0500 [thread overview]
Message-ID: <20190209064821.GG30548@zaya.teonanacatl.net> (raw)
In-Reply-To: <20190208203009.GC10587@szeder.dev>
[-cc: linux-kernel & git-packagers]
SZEDER Gábor wrote:
> On Fri, Feb 08, 2019 at 03:11:29PM -0500, Todd Zullinger wrote:
>> It made me wonder how I had missed it in my own testing.
>> This one requires SHELL_PATH to be bash, while I only set
>> TEST_SHELL_PATH to bash for the improved -x tracing in the
>> fedora builds.
>
> Note that you don't need Bash to use '-x' tracing since a5bf824f3b (t:
> prevent '-x' tracing from interfering with test helpers' stderr,
> 2018-02-25) and the followup commits, except for 't1510-repo-setup.sh'
> (and even t1510 just falls back to ignore '-x' instead of causing
> failures).
Huh, cool. I somehow missed that nice improvement. Thanks
for all your fine work on the test suite! It makes my life
as a packager much better having a robust test suite running
with each build.
--
Todd
prev parent reply other threads:[~2019-02-09 6:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 10:48 [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) Randall S. Becker
2019-02-08 10:55 ` Johannes Schindelin
2019-02-08 10:58 ` Randall S. Becker
2019-02-08 11:10 ` SZEDER Gábor
2019-02-08 11:36 ` Randall S. Becker
2019-02-08 20:11 ` Todd Zullinger
2019-02-08 20:30 ` SZEDER Gábor
2019-02-09 6:48 ` Todd Zullinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209064821.GG30548@zaya.teonanacatl.net \
--to=tmz@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).