From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>, git@vger.kernel.org
Subject: Re: [PATCH] Clear --exclude list after 'git rev-parse --all'
Date: Sat, 27 Oct 2018 03:20:57 -0400 [thread overview]
Message-ID: <20181027072056.GA26545@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq5zxnc17b.fsf@gitster-ct.c.googlers.com>
On Sat, Oct 27, 2018 at 04:12:40PM +0900, Junio C Hamano wrote:
> > Yeah, I agree that would be fine, too. I think there are two dimensions
> > in which to look at the problem, like so:
> >
> > rev-list rev-parse
> > -------- ---------
> > --glob clears clears
> > --all clears does not clear
> >
> > Testing either the row or the column (or both) works for me. :)
>
> OK, so let's not leave this loose end untied. This may be good
> enough to squash in.
> [...]
> +test_expect_success 'rev-parse --branches clears --exclude' '
> + compare rev-parse "--exclude=* --branches --branches" "--branches"
> +'
> +
> +test_expect_success 'rev-parse --tags clears --exclude' '
> + compare rev-parse "--exclude=* --tags --tags" "--tags"
> +'
> +
> +test_expect_success 'rev-parse --all clears --exclude' '
> + compare rev-parse "--exclude=* --all --all" "--all"
> +'
Yes, this looks good to me. In theory a more intricate test might catch
other kinds of bugs (e.g., a more limited exclude and making sure it was
applied correctly in each place), but I don't think it's really worth
the effort.
-Peff
prev parent reply other threads:[~2018-10-27 7:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 19:17 [PATCH] Clear --exclude list after 'git rev-parse --all' Andreas Gruenbacher
2018-10-24 4:35 ` Junio C Hamano
2018-10-24 9:01 ` Andreas Gruenbacher
2018-10-24 9:24 ` Junio C Hamano
2018-10-24 9:49 ` Andreas Gruenbacher
2018-10-25 10:45 ` Jeff King
2018-10-25 23:43 ` Junio C Hamano
2018-10-26 7:46 ` Jeff King
2018-10-27 7:12 ` Junio C Hamano
2018-10-27 7:20 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027072056.GA26545@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=agruenba@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).