From: Jeff King <peff@peff.net>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Clear --exclude list after 'git rev-parse --all'
Date: Thu, 25 Oct 2018 06:45:43 -0400 [thread overview]
Message-ID: <20181025104542.GA14455@sigill.intra.peff.net> (raw)
In-Reply-To: <CAHc6FU5CpBNpzfPs0hkNm9Hw1iYnALvUY4WL1z=sPVT10fq+zw@mail.gmail.com>
On Wed, Oct 24, 2018 at 11:49:06AM +0200, Andreas Gruenbacher wrote:
> > That is why I asked what "problem" this patch fixes. Without
> > answering that question, it is unclear if the patch is completing
> > missing coverage for "--all", or it is cargo culting an useless
> > clearing done for "--glob" and friends to code for "--all" that did
> > not do the same useless clearing.
>
> This is how the --exclude option is described:
>
> --exclude=<glob-pattern>
> Do not include refs matching <glob-pattern> that the next
> --all, --branches,
> --tags, --remotes, or --glob would otherwise consider.
> Repetitions of this
> option accumulate exclusion patterns up to the next --all,
> --branches, --tags,
> --remotes, or --glob option (other options or arguments do not clear
> accumulated patterns).
>
> I'm assuming that some thought has gone into making the options behave
> in this particular way. The implementation in revision.c follows this
> pattern, but the implementation in builtin/rev-parse.c only almost
> does.
Yeah. I think this is just a bug in 9dc01bf063 (rev-parse: introduce
--exclude=<glob> to tame wildcards, 2013-11-01), in that it's handling
of --all differed from e7b432c521 (revision: introduce --exclude=<glob>
to tame wildcards, 2013-08-30). The clearing is very much intentional
and documented, and in general rev-parse should behave the same as
rev-list.
An easy test is:
$ git rev-list --no-walk --exclude='*' --all --all
3289ca716320457af5d2dd550b716282ad22da11
...a bunch of other tip commits...
$ git rev-parse --exclude='*' --all --all
[no output, but it should print those same tip commits]
-Peff
next prev parent reply other threads:[~2018-10-25 10:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 19:17 [PATCH] Clear --exclude list after 'git rev-parse --all' Andreas Gruenbacher
2018-10-24 4:35 ` Junio C Hamano
2018-10-24 9:01 ` Andreas Gruenbacher
2018-10-24 9:24 ` Junio C Hamano
2018-10-24 9:49 ` Andreas Gruenbacher
2018-10-25 10:45 ` Jeff King [this message]
2018-10-25 23:43 ` Junio C Hamano
2018-10-26 7:46 ` Jeff King
2018-10-27 7:12 ` Junio C Hamano
2018-10-27 7:20 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025104542.GA14455@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=agruenba@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).