From: Jeff King <peff@peff.net>
To: Tao Qingyun <taoqy@ls-a.me>
Cc: avarab@gmail.com, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2] builtin/branch.c: remove useless branch_get
Date: Wed, 17 Oct 2018 04:39:07 -0400 [thread overview]
Message-ID: <20181017083906.GC31932@sigill.intra.peff.net> (raw)
In-Reply-To: <20181016145428.2901-1-taoqy@ls-a.me>
On Tue, Oct 16, 2018 at 10:54:28PM +0800, Tao Qingyun wrote:
> branch_get sometimes returns current_branch, which can be NULL (e.g., if
> you're on a detached HEAD). Try:
>
> $ git branch HEAD
> fatal: no such branch 'HEAD'
>
> $ git branch ''
> fatal: no such branch ''
>
> However, it seems weird that we'd check those cases here (and provide
> such lousy messages). And indeed, dropping that and letting us
> eventually hit create_branch() gives a much better message:
>
> $ git branch HEAD
> fatal: 'HEAD' is not a valid branch name.
>
> $ git branch ''
> fatal: '' is not a valid branch name.
This explanation is perfect, of course. ;)
I still wondered if you had another motivation hinted at in your
original mail, though (some weirdness with running branch_get early).
It's OK if there isn't one, but I just want to make sure we capture all
of the details.
Other than that question, the patch looks good to me.
-Peff
next prev parent reply other threads:[~2018-10-17 8:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 8:11 [Question] builtin/branch.c Tao Qingyun
2018-10-14 10:19 ` Ævar Arnfjörð Bjarmason
2018-10-15 14:08 ` [PATCH] builtin/branch.c: remove useless branch_get Tao Qingyun
2018-10-15 17:17 ` Jeff King
2018-10-16 14:54 ` [PATCH v2] " Tao Qingyun
2018-10-17 8:39 ` Jeff King [this message]
2018-10-17 12:58 ` Tao Qingyun
2018-10-15 17:14 ` [Question] builtin/branch.c Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017083906.GC31932@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=taoqy@ls-a.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).