From: Jeff King <peff@peff.net>
To: Tao Qingyun <taoqy@ls-a.me>
Cc: gitster@pobox.com, git@vger.kernel.org, avarab@gmail.com
Subject: Re: [PATCH] builtin/branch.c: remove useless branch_get
Date: Mon, 15 Oct 2018 13:17:07 -0400 [thread overview]
Message-ID: <20181015171707.GB1301@sigill.intra.peff.net> (raw)
In-Reply-To: <20181015140839.4925-1-taoqy@ls-a.me>
On Mon, Oct 15, 2018 at 10:08:39PM +0800, Tao Qingyun wrote:
> Signed-off-by: Tao Qingyun <taoqy@ls-a.me>
The commit message should describe the "why" here. I gave some reasoning
nearby in:
https://public-inbox.org/git/20181015171417.GA1301@sigill.intra.peff.net/
From your initial message, it sounds like this might also be fixing a
bug ("confusing that getting a branch before it has created"). Can you
describe that (and ideally show the fix with a test)?
> diff --git a/builtin/branch.c b/builtin/branch.c
> index c396c41533..2367703034 100644
> --- a/builtin/branch.c
> +++ b/builtin/branch.c
> @@ -809,11 +809,6 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
> git_config_set_multivar(buf.buf, NULL, NULL, 1);
> strbuf_release(&buf);
> } else if (argc > 0 && argc <= 2) {
> - struct branch *branch = branch_get(argv[0]);
> -
> - if (!branch)
> - die(_("no such branch '%s'"), argv[0]);
> -
From what I can tell, the patch itself _is_ an improvement. I just think
we need to explain why for the record.
-Peff
next prev parent reply other threads:[~2018-10-15 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 8:11 [Question] builtin/branch.c Tao Qingyun
2018-10-14 10:19 ` Ævar Arnfjörð Bjarmason
2018-10-15 14:08 ` [PATCH] builtin/branch.c: remove useless branch_get Tao Qingyun
2018-10-15 17:17 ` Jeff King [this message]
2018-10-16 14:54 ` [PATCH v2] " Tao Qingyun
2018-10-17 8:39 ` Jeff King
2018-10-17 12:58 ` Tao Qingyun
2018-10-15 17:14 ` [Question] builtin/branch.c Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015171707.GB1301@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=taoqy@ls-a.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).