* [PATCH] t/chainlint.sed: drop extra spaces from regex character class
@ 2018-07-31 5:03 Eric Sunshine
0 siblings, 0 replies; only message in thread
From: Eric Sunshine @ 2018-07-31 5:03 UTC (permalink / raw)
To: git; +Cc: Jonathan Nieder, Eric Sunshine
This character class, like many others in this script, matches
horizontal whitespace consisting of spaces and tabs, however, a few
extra, entirely harmless, spaces somehow slipped into the expression.
Removing them is purely a cosmetic fix.
While at it, re-indent three lines with a single TAB each which were
incorrectly indented with six spaces. Also, a purely cosmetic fix.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
Just something I noticed while examining t/chainlint.sed after reading
Jonathan's report[1] of a false-positive.
This is atop 'es/chain-lint-in-subshell' in 'next'.
[1]: https://public-inbox.org/git/20180730181356.GA156463@aiede.svl.corp.google.com/
t/chainlint.sed | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/chainlint.sed b/t/chainlint.sed
index a0de8a3882..5f0882cb38 100644
--- a/t/chainlint.sed
+++ b/t/chainlint.sed
@@ -71,9 +71,9 @@
# incomplete line -- slurp up next line
:squash
/\\$/ {
- N
- s/\\\n//
- bsquash
+ N
+ s/\\\n//
+ bsquash
}
# here-doc -- swallow it to avoid false hits within its body (but keep the
@@ -199,7 +199,7 @@ s/.*\n//
# "$(...)" -- command substitution; not closing ")"
/\$([^)][^)]*)[^)]*$/bcheckchain
# multi-line "$(...\n...)" -- command substitution; treat as nested subshell
-/\$([ ]*$/bnest
+/\$([ ]*$/bnest
# "=(...)" -- Bash array assignment; not closing ")"
/=(/bcheckchain
# closing "...) &&"
--
2.18.0.597.ga71716f1ad
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-07-31 5:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-31 5:03 [PATCH] t/chainlint.sed: drop extra spaces from regex character class Eric Sunshine
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).