From: Max Kirillov <max@max630.net>
To: Jeff King <peff@peff.net>
Cc: Max Kirillov <max@max630.net>, Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Florian Manschwetus <manschwetus@cs-software-gmbh.de>,
Chris Packham <judge.packham@gmail.com>,
Konstantin Khomoutov <kostix+git@007spb.ru>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v7 2/2] http-backend: respect CONTENT_LENGTH for receive-pack
Date: Sun, 10 Jun 2018 18:07:27 +0300 [thread overview]
Message-ID: <20180610150727.GE27650@jessie.local> (raw)
In-Reply-To: <20180604044408.GD14451@sigill.intra.peff.net>
On Mon, Jun 04, 2018 at 12:44:09AM -0400, Jeff King wrote:
> On Sun, Jun 03, 2018 at 12:27:49AM +0300, Max Kirillov wrote:
>> + env \
>> + CONTENT_TYPE=application/x-git-upload-pack-request \
>> + QUERY_STRING=/repo.git/git-upload-pack \
>> + PATH_TRANSLATED="$PWD"/.git/git-upload-pack \
>> + GIT_HTTP_EXPORT_ALL=TRUE \
>> + REQUEST_METHOD=POST \
>> + CONTENT_LENGTH="$NOT_FIT_IN_SSIZE" \
>> + git http-backend </dev/zero >/dev/null 2>err &&
>> + grep -q "fatal:.*CONTENT_LENGTH" err
>
> I'm not sure if these messages should be marked for translation. If so,
> you'd want test_i18ngrep here.
Message localization does not seem to be used in
http-backend at all. It makes sense - server-side software
probably does not know who is the user on the other side, if
the message gets to the user at all. So, I think the
message should not be translated.
next prev parent reply other threads:[~2018-06-10 15:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 21:27 [PATCH v7 0/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-06-02 21:27 ` [PATCH v7 1/2] " Max Kirillov
2018-06-04 3:44 ` Jeff King
2018-06-02 21:27 ` [PATCH v7 2/2] http-backend: respect CONTENT_LENGTH for receive-pack Max Kirillov
2018-06-04 4:31 ` Junio C Hamano
2018-06-04 17:06 ` Max Kirillov
2018-06-05 2:30 ` Ramsay Jones
2018-06-04 4:44 ` Jeff King
2018-06-04 22:18 ` Max Kirillov
2018-06-10 15:06 ` Max Kirillov
2018-06-11 9:18 ` Jeff King
2018-06-11 9:24 ` Jeff King
2018-06-10 15:07 ` Max Kirillov [this message]
2018-06-11 8:59 ` Jeff King
2018-06-10 15:05 ` [PATCH v8 0/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-06-10 15:05 ` [PATCH v8 1/3] http-backend: cleanup writing to child process Max Kirillov
2018-06-10 15:05 ` [PATCH v8 2/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-06-10 15:05 ` [PATCH v8 3/3] http-backend: respect CONTENT_LENGTH for receive-pack Max Kirillov
2018-07-25 12:14 ` SZEDER Gábor
2018-07-25 14:51 ` Max Kirillov
2018-07-25 18:41 ` SZEDER Gábor
2018-07-26 4:37 ` Max Kirillov
2018-07-27 3:48 ` [PATCH v9 0/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-07-27 3:48 ` [PATCH v9 1/3] http-backend: cleanup writing to child process Max Kirillov
2018-07-27 3:48 ` [PATCH v9 2/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-08-04 6:34 ` Duy Nguyen
2018-08-04 11:28 ` Max Kirillov
2018-08-04 17:20 ` Junio C Hamano
2018-07-27 3:48 ` [PATCH v9 3/3] http-backend: respect CONTENT_LENGTH for receive-pack Max Kirillov
2018-07-27 3:50 ` [PATCH v9 0/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-07-27 17:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180610150727.GE27650@jessie.local \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=judge.packham@gmail.com \
--cc=kostix+git@007spb.ru \
--cc=manschwetus@cs-software-gmbh.de \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).