From: Max Kirillov <max@max630.net>
To: Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Jeff King <peff@peff.net>
Cc: Max Kirillov <max@max630.net>,
Florian Manschwetus <manschwetus@cs-software-gmbh.de>,
Chris Packham <judge.packham@gmail.com>,
Konstantin Khomoutov <kostix+git@007spb.ru>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: [PATCH v7 0/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875
Date: Sun, 3 Jun 2018 00:27:47 +0300 [thread overview]
Message-ID: <20180602212749.21324-1-max@max630.net> (raw)
In-Reply-To: 20171126193813.12531-1-max@max630.net
It's been time. Thank you for parience.
Changes:
* did most of the changes proposed
* rebase to newer master (latest conflicting change is addition of combined test helper)
* make tests which cover, hopefully, all cases.
* handle incorectly truncated input also in receive-pack. Considering the complications
pointed out by Jeff, it just filters the input in the frontend process. I hope it
is acceptable thing to do.
Max Kirillov (2):
http-backend: respect CONTENT_LENGTH as specified by rfc3875
http-backend: respect CONTENT_LENGTH for receive-pack
Makefile | 1 +
config.c | 2 +-
config.h | 1 +
http-backend.c | 86 +++++++++++--
t/helper/test-print-larger-than-ssize.c | 11 ++
t/helper/test-tool.c | 1 +
t/helper/test-tool.h | 1 +
t/t5560-http-backend-noserver.sh | 13 ++
t/t5562-http-backend-content-length.sh | 155 ++++++++++++++++++++++++
t/t5562/invoke-with-content-length.pl | 30 +++++
10 files changed, 291 insertions(+), 10 deletions(-)
create mode 100644 t/helper/test-print-larger-than-ssize.c
create mode 100755 t/t5562-http-backend-content-length.sh
create mode 100755 t/t5562/invoke-with-content-length.pl
--
2.17.0.1185.g782057d875
next reply other threads:[~2018-06-02 21:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 21:27 Max Kirillov [this message]
2018-06-02 21:27 ` [PATCH v7 1/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-06-04 3:44 ` Jeff King
2018-06-02 21:27 ` [PATCH v7 2/2] http-backend: respect CONTENT_LENGTH for receive-pack Max Kirillov
2018-06-04 4:31 ` Junio C Hamano
2018-06-04 17:06 ` Max Kirillov
2018-06-05 2:30 ` Ramsay Jones
2018-06-04 4:44 ` Jeff King
2018-06-04 22:18 ` Max Kirillov
2018-06-10 15:06 ` Max Kirillov
2018-06-11 9:18 ` Jeff King
2018-06-11 9:24 ` Jeff King
2018-06-10 15:07 ` Max Kirillov
2018-06-11 8:59 ` Jeff King
2018-06-10 15:05 ` [PATCH v8 0/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-06-10 15:05 ` [PATCH v8 1/3] http-backend: cleanup writing to child process Max Kirillov
2018-06-10 15:05 ` [PATCH v8 2/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-06-10 15:05 ` [PATCH v8 3/3] http-backend: respect CONTENT_LENGTH for receive-pack Max Kirillov
2018-07-25 12:14 ` SZEDER Gábor
2018-07-25 14:51 ` Max Kirillov
2018-07-25 18:41 ` SZEDER Gábor
2018-07-26 4:37 ` Max Kirillov
2018-07-27 3:48 ` [PATCH v9 0/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-07-27 3:48 ` [PATCH v9 1/3] http-backend: cleanup writing to child process Max Kirillov
2018-07-27 3:48 ` [PATCH v9 2/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-08-04 6:34 ` Duy Nguyen
2018-08-04 11:28 ` Max Kirillov
2018-08-04 17:20 ` Junio C Hamano
2018-07-27 3:48 ` [PATCH v9 3/3] http-backend: respect CONTENT_LENGTH for receive-pack Max Kirillov
2018-07-27 3:50 ` [PATCH v9 0/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-07-27 17:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180602212749.21324-1-max@max630.net \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=judge.packham@gmail.com \
--cc=kostix+git@007spb.ru \
--cc=manschwetus@cs-software-gmbh.de \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).