From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] make show-index a builtin
Date: Mon, 28 May 2018 13:57:55 -0400 [thread overview]
Message-ID: <20180528175754.GA20636@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqlgc3iyom.fsf@gitster-ct.c.googlers.com>
On Tue, May 29, 2018 at 12:31:53AM +0900, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > diff --git a/show-index.c b/builtin/show-index.c
> > similarity index 96%
> > rename from show-index.c
> > rename to builtin/show-index.c
> > index 1ead41e211..65fa86dd08 100644
> > --- a/show-index.c
> > +++ b/builtin/show-index.c
> > @@ -4,7 +4,7 @@
>
> I squashed
>
> #include "builtin.h"
>
> near the beginning of this file to squelch -DDEVELOPER extra
> warnings. Otherwise looks obviously good.
Thanks. I'm still using my custom build options, and obviously I need to
add -Wmissing-prototypes.
> > diff --git a/git.c b/git.c
> > index 5771d62a32..c91e144d9a 100644
> > --- a/git.c
> > +++ b/git.c
> > @@ -470,6 +470,7 @@ static struct cmd_struct commands[] = {
> > { "shortlog", cmd_shortlog, RUN_SETUP_GENTLY | USE_PAGER },
> > { "show", cmd_show, RUN_SETUP },
> > { "show-branch", cmd_show_branch, RUN_SETUP },
> > + { "show-index", cmd_show_index },
>
> Hmph, this does not need SETUP? Ah, of course, because its
> subcommand body used to do everything itself, and this patch just
> turns cmd_main() to cmd_show_index().
It is not even that it does the setup itself. It does not need the setup
at all, because it is purely a mechanical parsing of the stdin stream
to text output. No repo required, and it does not know or care if the
matching packfile even exists.
-Peff
next prev parent reply other threads:[~2018-05-28 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 9:37 [PATCH 0/2] minor show-index modernizations Jeff King
2018-05-28 9:38 ` [PATCH 1/2] make show-index a builtin Jeff King
2018-05-28 15:31 ` Junio C Hamano
2018-05-28 17:57 ` Jeff King [this message]
2018-05-28 9:39 ` [PATCH 2/2] show-index: update documentation for index v2 Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528175754.GA20636@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).