From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/2] minor show-index modernizations
Date: Mon, 28 May 2018 05:37:40 -0400 [thread overview]
Message-ID: <20180528093740.GA6902@sigill.intra.peff.net> (raw)
While recommending show-index to somebody today, I noticed that it has a
few ancient warts. This series turns it into a builtin and fixes the
documentation. I suspect it could do with some more modernization and
friendliness, like:
- re-using the existing packfile.c code instead of re-implementing
index-reading (though the packfile code would definitely need some
refactoring to make this work)
- it could probably handle arguments as files instead of requiring
stdin redirection
I'll leave those for now, as they're not worth the effort to me at this
point. But everybody who _doesn't_ use the command benefits from making
it a builtin, so it seems like an easy win.
[1/2]: make show-index a builtin
[2/2]: show-index: update documentation for index v2
Documentation/git-show-index.txt | 22 ++++++++++++++++------
Makefile | 2 +-
builtin.h | 1 +
show-index.c => builtin/show-index.c | 2 +-
git.c | 1 +
5 files changed, 20 insertions(+), 8 deletions(-)
rename show-index.c => builtin/show-index.c (96%)
-Peff
next reply other threads:[~2018-05-28 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 9:37 Jeff King [this message]
2018-05-28 9:38 ` [PATCH 1/2] make show-index a builtin Jeff King
2018-05-28 15:31 ` Junio C Hamano
2018-05-28 17:57 ` Jeff King
2018-05-28 9:39 ` [PATCH 2/2] show-index: update documentation for index v2 Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528093740.GA6902@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).