From: Casey Fitzpatrick <kcghost@gmail.com>
To: git@vger.kernel.org, sbeller@google.com, sunshine@sunshineco.com
Cc: Casey Fitzpatrick <kcghost@gmail.com>
Subject: [PATCH 1/3] submodule: clean up subsititions in script
Date: Tue, 1 May 2018 20:55:26 -0400 [thread overview]
Message-ID: <20180502005528.19740-2-kcghost@gmail.com> (raw)
In-Reply-To: <20180502005528.19740-1-kcghost@gmail.com>
'recommend_shallow' and 'jobs' variables do not need quotes (they never contain
spaces) and do not require any additional prefix, therefore remove the
unnecessary subsitition.
'progress' is a boolean value. Treat it like the other boolean values in the
script by using a substitution.
Signed-off-by: Casey Fitzpatrick <kcghost@gmail.com>
---
git-submodule.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 24914963c..262547968 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -465,7 +465,7 @@ cmd_update()
GIT_QUIET=1
;;
--progress)
- progress="--progress"
+ progress=1
;;
-i|--init)
init=1
@@ -542,14 +542,14 @@ cmd_update()
{
git submodule--helper update-clone ${GIT_QUIET:+--quiet} \
- ${progress:+"$progress"} \
+ ${progress:+"--progress"} \
${wt_prefix:+--prefix "$wt_prefix"} \
${prefix:+--recursive-prefix "$prefix"} \
${update:+--update "$update"} \
${reference:+"$reference"} \
${depth:+--depth "$depth"} \
- ${recommend_shallow:+"$recommend_shallow"} \
- ${jobs:+$jobs} \
+ $recommend_shallow \
+ $jobs \
"$@" || echo "#unmatched" $?
} | {
err=
--
2.17.0.1.ge0414f29c.dirty
next prev parent reply other threads:[~2018-05-02 1:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 8:29 git-submodule is missing --dissociate option Casey Fitzpatrick
2018-04-30 11:30 ` Casey Fitzpatrick
2018-04-30 13:16 ` Ævar Arnfjörð Bjarmason
2018-05-02 4:32 ` Junio C Hamano
2018-04-30 18:19 ` Stefan Beller
2018-04-30 21:39 ` Casey Fitzpatrick
2018-05-01 18:09 ` [PATCH 0/2] Add --progress and --dissociate to git submodule Casey Fitzpatrick
2018-05-01 18:09 ` [PATCH 1/2] submodule: Add --progress option to add command Casey Fitzpatrick
2018-05-01 18:41 ` Stefan Beller
2018-05-01 20:48 ` Casey Fitzpatrick
2018-05-01 18:09 ` [PATCH 2/2] submodule: Add --dissociate option to add/update commands Casey Fitzpatrick
2018-05-01 20:23 ` Stefan Beller
2018-05-01 20:25 ` Eric Sunshine
2018-05-01 21:21 ` Casey Fitzpatrick
2018-05-01 18:20 ` [PATCH 0/2] Add --progress and --dissociate to git submodule Stefan Beller
2018-05-02 0:27 ` [PATCH 0/3] " Casey Fitzpatrick
2018-05-02 0:27 ` [PATCH 1/3] submodule: clean up subsititions in script Casey Fitzpatrick
2018-05-02 0:27 ` [PATCH 2/3] submodule: add --progress option to add command Casey Fitzpatrick
2018-05-02 0:27 ` [PATCH 3/3] submodule: add --dissociate option to add/update commands Casey Fitzpatrick
2018-05-02 0:40 ` Casey Fitzpatrick
2018-05-02 0:55 ` [PATCH 0/3] Add --progress and --dissociate to git submodule Casey Fitzpatrick
2018-05-02 0:55 ` Casey Fitzpatrick [this message]
2018-05-02 5:59 ` [PATCH 1/3] submodule: clean up subsititions in script Junio C Hamano
2018-05-03 10:46 ` Casey Fitzpatrick
2018-05-02 0:55 ` [PATCH 2/3] submodule: add --progress option to add command Casey Fitzpatrick
2018-05-02 0:55 ` [PATCH 3/3] submodule: add --dissociate option to add/update commands Casey Fitzpatrick
2018-05-02 4:37 ` [PATCH 0/3] Add --progress and --dissociate to git submodule Junio C Hamano
2018-05-02 8:54 ` Casey Fitzpatrick
2018-05-02 4:34 ` git-submodule is missing --dissociate option Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502005528.19740-2-kcghost@gmail.com \
--to=kcghost@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).