git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Casey Fitzpatrick <kcghost@gmail.com>
To: git <git@vger.kernel.org>, Stefan Beller <sbeller@google.com>,
	Eric Sunshine <sunshine@sunshineco.com>
Cc: Casey Fitzpatrick <kcghost@gmail.com>
Subject: Re: [PATCH 3/3] submodule: add --dissociate option to add/update commands
Date: Tue, 1 May 2018 20:40:22 -0400	[thread overview]
Message-ID: <CAEp-SHXmWv=peu3-j3AodAhwAPgyPNVrTE4DJuFcr0mTn2M3iw@mail.gmail.com> (raw)
In-Reply-To: <20180502002759.8207-4-kcghost@gmail.com>

Just noticed I missed the other 'test_must_fail'. Resubmitting in a few moments.

On Tue, May 1, 2018 at 8:27 PM, Casey Fitzpatrick <kcghost@gmail.com> wrote:
> Add --dissociate option to add and update commands, both clone helper commands
> that already have the --reference option --dissociate pairs with.
>
> Signed-off-by: Casey Fitzpatrick <kcghost@gmail.com>
> ---
>  Documentation/git-submodule.txt | 10 +++++++++-
>  builtin/submodule--helper.c     | 16 +++++++++++++---
>  git-submodule.sh                | 10 +++++++++-
>  t/t7408-submodule-reference.sh  | 17 +++++++++++++++++
>  4 files changed, 48 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
> index d1ebe32e8..a75b95043 100644
> --- a/Documentation/git-submodule.txt
> +++ b/Documentation/git-submodule.txt
> @@ -369,7 +369,15 @@ the submodule itself.
>         this option will be passed to the linkgit:git-clone[1] command.
>  +
>  *NOTE*: Do *not* use this option unless you have read the note
> -for linkgit:git-clone[1]'s `--reference` and `--shared` options carefully.
> +for linkgit:git-clone[1]'s `--reference`, `--shared`, and `--dissociate`
> +options carefully.
> +
> +--dissociate::
> +       This option is only valid for add and update commands.  These
> +       commands sometimes need to clone a remote repository. In this case,
> +       this option will be passed to the linkgit:git-clone[1] command.
> ++
> +*NOTE*: see the NOTE for the `--reference` option.
>
>  --recursive::
>         This option is only valid for foreach, update, status and sync commands.
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index 6ba8587b6..a85b30419 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -1056,7 +1056,7 @@ static int module_deinit(int argc, const char **argv, const char *prefix)
>  }
>
>  static int clone_submodule(const char *path, const char *gitdir, const char *url,
> -                          const char *depth, struct string_list *reference,
> +                          const char *depth, struct string_list *reference, int dissociate,
>                            int quiet, int progress)
>  {
>         struct child_process cp = CHILD_PROCESS_INIT;
> @@ -1075,6 +1075,8 @@ static int clone_submodule(const char *path, const char *gitdir, const char *url
>                         argv_array_pushl(&cp.args, "--reference",
>                                          item->string, NULL);
>         }
> +       if (dissociate)
> +               argv_array_push(&cp.args, "--dissociate");
>         if (gitdir && *gitdir)
>                 argv_array_pushl(&cp.args, "--separate-git-dir", gitdir, NULL);
>
> @@ -1190,6 +1192,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
>         char *p, *path = NULL, *sm_gitdir;
>         struct strbuf sb = STRBUF_INIT;
>         struct string_list reference = STRING_LIST_INIT_NODUP;
> +       int dissociate = 0;
>         char *sm_alternate = NULL, *error_strategy = NULL;
>
>         struct option module_clone_options[] = {
> @@ -1208,6 +1211,8 @@ static int module_clone(int argc, const char **argv, const char *prefix)
>                 OPT_STRING_LIST(0, "reference", &reference,
>                            N_("repo"),
>                            N_("reference repository")),
> +               OPT_BOOL(0, "dissociate", &dissociate,
> +                          N_("use --reference only while cloning")),
>                 OPT_STRING(0, "depth", &depth,
>                            N_("string"),
>                            N_("depth for shallow clones")),
> @@ -1247,7 +1252,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
>
>                 prepare_possible_alternates(name, &reference);
>
> -               if (clone_submodule(path, sm_gitdir, url, depth, &reference,
> +               if (clone_submodule(path, sm_gitdir, url, depth, &reference, dissociate,
>                                     quiet, progress))
>                         die(_("clone of '%s' into submodule path '%s' failed"),
>                             url, path);
> @@ -1300,6 +1305,7 @@ struct submodule_update_clone {
>         int quiet;
>         int recommend_shallow;
>         struct string_list references;
> +       int dissociate;
>         const char *depth;
>         const char *recursive_prefix;
>         const char *prefix;
> @@ -1315,7 +1321,7 @@ struct submodule_update_clone {
>         int failed_clones_nr, failed_clones_alloc;
>  };
>  #define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \
> -       SUBMODULE_UPDATE_STRATEGY_INIT, 0, 0, -1, STRING_LIST_INIT_DUP, \
> +       SUBMODULE_UPDATE_STRATEGY_INIT, 0, 0, -1, STRING_LIST_INIT_DUP, 0, \
>         NULL, NULL, NULL, \
>         STRING_LIST_INIT_DUP, 0, NULL, 0, 0}
>
> @@ -1442,6 +1448,8 @@ static int prepare_to_clone_next_submodule(const struct cache_entry *ce,
>                 for_each_string_list_item(item, &suc->references)
>                         argv_array_pushl(&child->args, "--reference", item->string, NULL);
>         }
> +       if (suc->dissociate)
> +               argv_array_push(&child->args, "--dissociate");
>         if (suc->depth)
>                 argv_array_push(&child->args, suc->depth);
>
> @@ -1575,6 +1583,8 @@ static int update_clone(int argc, const char **argv, const char *prefix)
>                            N_("rebase, merge, checkout or none")),
>                 OPT_STRING_LIST(0, "reference", &suc.references, N_("repo"),
>                            N_("reference repository")),
> +               OPT_BOOL(0, "dissociate", &suc.dissociate,
> +                          N_("use --reference only while cloning")),
>                 OPT_STRING(0, "depth", &suc.depth, "<depth>",
>                            N_("Create a shallow clone truncated to the "
>                               "specified number of revisions")),
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 39c241a1d..1fddc098f 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -42,6 +42,7 @@ prefix=
>  custom_name=
>  depth=
>  progress=
> +dissociate=
>
>  die_if_unmatched ()
>  {
> @@ -128,6 +129,9 @@ cmd_add()
>                 --reference=*)
>                         reference_path="${1#--reference=}"
>                         ;;
> +               --dissociate)
> +                       dissociate=1
> +                       ;;
>                 --name)
>                         case "$2" in '') usage ;; esac
>                         custom_name=$2
> @@ -258,7 +262,7 @@ or you are unsure what this means choose another name with the '--name' option."
>                                 eval_gettextln "Reactivating local git directory for submodule '\$sm_name'."
>                         fi
>                 fi
> -               git submodule--helper clone ${GIT_QUIET:+--quiet} ${progress:+"--progress"} --prefix "$wt_prefix" --path "$sm_path" --name "$sm_name" --url "$realrepo" ${reference:+"$reference"} ${depth:+"$depth"} || exit
> +               git submodule--helper clone ${GIT_QUIET:+--quiet} ${progress:+"--progress"} --prefix "$wt_prefix" --path "$sm_path" --name "$sm_name" --url "$realrepo" ${reference:+"$reference"} ${dissociate:+"--dissociate"} ${depth:+"$depth"} || exit
>                 (
>                         sanitize_submodule_env
>                         cd "$sm_path" &&
> @@ -493,6 +497,9 @@ cmd_update()
>                 --reference=*)
>                         reference="$1"
>                         ;;
> +               --dissociate)
> +                       dissociate=1
> +                       ;;
>                 -m|--merge)
>                         update="merge"
>                         ;;
> @@ -550,6 +557,7 @@ cmd_update()
>                 ${prefix:+--recursive-prefix "$prefix"} \
>                 ${update:+--update "$update"} \
>                 ${reference:+"$reference"} \
> +               ${dissociate:+"--dissociate"} \
>                 ${depth:+--depth "$depth"} \
>                 $recommend_shallow \
>                 $jobs \
> diff --git a/t/t7408-submodule-reference.sh b/t/t7408-submodule-reference.sh
> index e159fc503..1b3e7c2f7 100755
> --- a/t/t7408-submodule-reference.sh
> +++ b/t/t7408-submodule-reference.sh
> @@ -59,6 +59,16 @@ test_expect_success 'submodule add --reference uses alternates' '
>         test_alternate_is_used super/.git/modules/sub/objects/info/alternates super/sub
>  '
>
> +test_expect_success 'submodule add --reference with --dissociate doesnt use alternates' '
> +       (
> +               cd super &&
> +               git submodule add --reference ../B --dissociate "file://$base_dir/A" sub-dissociate &&
> +               git commit -m B-super-added &&
> +               git repack -ad
> +       ) &&
> +       test_path_is_missing super/.git/modules/sub-dissociate/objects/info/alternates
> +'
> +
>  test_expect_success 'that reference gets used with add' '
>         (
>                 cd super/sub &&
> @@ -82,6 +92,13 @@ test_expect_success 'updating superproject keeps alternates' '
>         test_alternate_is_used super-clone/.git/modules/sub/objects/info/alternates super-clone/sub
>  '
>
> +test_expect_success 'updating superproject with --dissociate doesnt keep alternates' '
> +       test_when_finished "rm -rf super-clone" &&
> +       git clone super super-clone &&
> +       git -C super-clone submodule update --init --reference ../B --dissociate &&
> +       test_must_fail test_alternate_is_used super-clone/.git/modules/sub/objects/info/alternates super-clone/sub
> +'
> +
>  test_expect_success 'submodules use alternates when cloning a superproject' '
>         test_when_finished "rm -rf super-clone" &&
>         git clone --reference super --recursive super super-clone &&
> --
> 2.17.0.1.ge0414f29c.dirty
>

  reply	other threads:[~2018-05-02  0:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30  8:29 git-submodule is missing --dissociate option Casey Fitzpatrick
2018-04-30 11:30 ` Casey Fitzpatrick
2018-04-30 13:16   ` Ævar Arnfjörð Bjarmason
2018-05-02  4:32     ` Junio C Hamano
2018-04-30 18:19 ` Stefan Beller
2018-04-30 21:39   ` Casey Fitzpatrick
2018-05-01 18:09     ` [PATCH 0/2] Add --progress and --dissociate to git submodule Casey Fitzpatrick
2018-05-01 18:09       ` [PATCH 1/2] submodule: Add --progress option to add command Casey Fitzpatrick
2018-05-01 18:41         ` Stefan Beller
2018-05-01 20:48           ` Casey Fitzpatrick
2018-05-01 18:09       ` [PATCH 2/2] submodule: Add --dissociate option to add/update commands Casey Fitzpatrick
2018-05-01 20:23         ` Stefan Beller
2018-05-01 20:25         ` Eric Sunshine
2018-05-01 21:21           ` Casey Fitzpatrick
2018-05-01 18:20       ` [PATCH 0/2] Add --progress and --dissociate to git submodule Stefan Beller
2018-05-02  0:27     ` [PATCH 0/3] " Casey Fitzpatrick
2018-05-02  0:27       ` [PATCH 1/3] submodule: clean up subsititions in script Casey Fitzpatrick
2018-05-02  0:27       ` [PATCH 2/3] submodule: add --progress option to add command Casey Fitzpatrick
2018-05-02  0:27       ` [PATCH 3/3] submodule: add --dissociate option to add/update commands Casey Fitzpatrick
2018-05-02  0:40         ` Casey Fitzpatrick [this message]
2018-05-02  0:55     ` [PATCH 0/3] Add --progress and --dissociate to git submodule Casey Fitzpatrick
2018-05-02  0:55       ` [PATCH 1/3] submodule: clean up subsititions in script Casey Fitzpatrick
2018-05-02  5:59         ` Junio C Hamano
2018-05-03 10:46           ` Casey Fitzpatrick
2018-05-02  0:55       ` [PATCH 2/3] submodule: add --progress option to add command Casey Fitzpatrick
2018-05-02  0:55       ` [PATCH 3/3] submodule: add --dissociate option to add/update commands Casey Fitzpatrick
2018-05-02  4:37       ` [PATCH 0/3] Add --progress and --dissociate to git submodule Junio C Hamano
2018-05-02  8:54         ` Casey Fitzpatrick
2018-05-02  4:34   ` git-submodule is missing --dissociate option Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEp-SHXmWv=peu3-j3AodAhwAPgyPNVrTE4DJuFcr0mTn2M3iw@mail.gmail.com' \
    --to=kcghost@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sbeller@google.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).