From: Jeff King <email@example.com> To: Jeff Hostetler <firstname.lastname@example.org> Cc: Ben Peart <email@example.com>, firstname.lastname@example.org, email@example.com, Jeff Hostetler <firstname.lastname@example.org> Subject: Re: [PATCH v4 0/4] Add --no-ahead-behind to status Date: Tue, 9 Jan 2018 02:20:44 -0500 [thread overview] Message-ID: <20180109072044.GD32257@sigill.intra.peff.net> (raw) In-Reply-To: <email@example.com> On Mon, Jan 08, 2018 at 03:04:20PM -0500, Jeff Hostetler wrote: > > I was thinking about something similar to the logic we use today > > about whether to start reporting progress on other long commands. > > That would mean you could still get the ahead/behind values if you > > aren't that far behind but would only get "different" if that > > calculation gets too expensive (which implies the actual value isn't > > going to be all that helpful anyway). > > After a off-line conversation with the others I'm going to look into > a version that is limited to n commits rather than be completely on or > off. I think if you are for example less than 100 a/b then those numbers > have value; if you are past n, then they have much less value. > > I'd rather do it by a fixed limit than by time to ensure that output > is predictable on graph shape and not on system load. I like this direction a lot. I had hoped we could say "100+ commits ahead", but I don't think we can do so accurately without generation numbers. E.g., the case I mentioned at the bottom of this mail: https://public-inbox.org/git/20171224143318.GC23648@sigill.intra.peff.net/ I haven't thought too hard on it, but I suspect with generation numbers you could bound it and at least say "100+ ahead" or "100+ behind". But I don't think you can approximate both ahead and behind together without finding the actual merge base. But even still, finding small answers quickly and accurately and punting to "really far, I didn't bother to compute it" on the big ones would be an improvement over always punting. -Peff
next prev parent reply other threads:[~2018-01-09 7:20 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-08 15:48 Jeff Hostetler 2018-01-08 15:48 ` [PATCH v4 1/4] stat_tracking_info: return +1 when branches not equal Jeff Hostetler 2018-01-08 15:48 ` [PATCH v4 2/4] status: add --[no-]ahead-behind to status and commit for V2 format Jeff Hostetler 2018-01-08 15:48 ` [PATCH v4 3/4] status: update short status to respect --no-ahead-behind Jeff Hostetler 2018-01-08 15:48 ` [PATCH v4 4/4] status: support --no-ahead-behind in long format Jeff Hostetler 2018-01-08 19:49 ` [PATCH v4 0/4] Add --no-ahead-behind to status Ben Peart 2018-01-08 20:04 ` Jeff Hostetler 2018-01-09 7:20 ` Jeff King [this message] 2018-01-09 13:15 ` Johannes Schindelin 2018-01-09 14:29 ` Derrick Stolee 2018-01-09 14:56 ` Jeff Hostetler 2018-01-09 16:48 ` Johannes Schindelin 2018-01-10 7:47 ` Jeff King 2018-01-10 20:22 ` Junio C Hamano 2018-01-11 9:39 ` Jeff King 2018-01-10 7:41 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180109072044.GD32257@sigill.intra.peff.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v4 0/4] Add --no-ahead-behind to status' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).