From: Johannes Schindelin <Johannes.Schindelin@gmx.de> To: Derrick Stolee <firstname.lastname@example.org> Cc: Jeff King <email@example.com>, Jeff Hostetler <firstname.lastname@example.org>, Ben Peart <email@example.com>, firstname.lastname@example.org, email@example.com, Jeff Hostetler <firstname.lastname@example.org> Subject: Re: [PATCH v4 0/4] Add --no-ahead-behind to status Date: Tue, 9 Jan 2018 17:48:58 +0100 (STD) [thread overview] Message-ID: <nycvar.QRO.18.104.22.1681091744540.37@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz> (raw) In-Reply-To: <email@example.com> Hi Stolee, On Tue, 9 Jan 2018, Derrick Stolee wrote: > On 1/9/2018 8:15 AM, Johannes Schindelin wrote: > > > > On Tue, 9 Jan 2018, Jeff King wrote: > > > > > But I don't think you can approximate both ahead and behind together > > > without finding the actual merge base. > > > > > > But even still, finding small answers quickly and accurately and > > > punting to "really far, I didn't bother to compute it" on the big > > > ones would be an improvement over always punting. > > > > Indeed. The longer I think about it, the more I like the "100+ commits > > apart" idea. > > Again, I strongly suggest we drop this approach because it will be more pain > than it is worth. So what you are saying is if there is a commit graph with *heavy* clock skew, you might overestimate how many commits apart the tips are. I say that this is striking the balance between correctness and usability on the *wrong* side. Sure, it might be wrong if your commit graph suffers heavily from clock skew. In most cases, you still get a pretty darn useful hint where you're at. The alternative would be *not* to show any useful hint in most cases, i.e. when you did not find all merge bases within <N> commits. I would really hate it if Git spent so much time and did not even give me a hint. Totally unsatisfying user experience. Ciao, Johannes
next prev parent reply other threads:[~2018-01-09 16:49 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-08 15:48 Jeff Hostetler 2018-01-08 15:48 ` [PATCH v4 1/4] stat_tracking_info: return +1 when branches not equal Jeff Hostetler 2018-01-08 15:48 ` [PATCH v4 2/4] status: add --[no-]ahead-behind to status and commit for V2 format Jeff Hostetler 2018-01-08 15:48 ` [PATCH v4 3/4] status: update short status to respect --no-ahead-behind Jeff Hostetler 2018-01-08 15:48 ` [PATCH v4 4/4] status: support --no-ahead-behind in long format Jeff Hostetler 2018-01-08 19:49 ` [PATCH v4 0/4] Add --no-ahead-behind to status Ben Peart 2018-01-08 20:04 ` Jeff Hostetler 2018-01-09 7:20 ` Jeff King 2018-01-09 13:15 ` Johannes Schindelin 2018-01-09 14:29 ` Derrick Stolee 2018-01-09 14:56 ` Jeff Hostetler 2018-01-09 16:48 ` Johannes Schindelin [this message] 2018-01-10 7:47 ` Jeff King 2018-01-10 20:22 ` Junio C Hamano 2018-01-11 9:39 ` Jeff King 2018-01-10 7:41 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=nycvar.QRO.22.214.171.1241091744540.37@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v4 0/4] Add --no-ahead-behind to status' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).