From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] fmt-merge-msg: avoid leaking strbuf in shortlog()
Date: Wed, 20 Dec 2017 08:05:02 -0500 [thread overview]
Message-ID: <20171220130501.GC17569@sigill.intra.peff.net> (raw)
In-Reply-To: <f79ae9a3-de47-c41e-fea6-6a0fedf4ef63@web.de>
On Tue, Dec 19, 2017 at 07:26:06PM +0100, René Scharfe wrote:
> > That's the same duality we have now with string_list.
>
> Hmm, I thought we *were* discussing string_list?
Right, I guess what I was wondering is if a wrapper over string_list
really ends up any better than having the dual-natured string_list.
If they both use the same struct, then your wrappers are all just
functions. And isn't that more or less what we have now?
If they're actually different structs, then that complicates call
signatures for functions that take a list (unless we are getting into
polymorphism, they need to specify one of the types, even if they don't
particularly care whether it's an allocated list or not).
-Peff
next prev parent reply other threads:[~2017-12-20 13:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 20:22 [PATCH] fmt-merge-msg: avoid leaking strbuf in shortlog() René Scharfe
2017-12-07 21:27 ` Jeff King
2017-12-08 17:29 ` René Scharfe
2017-12-08 18:44 ` Junio C Hamano
2017-12-08 20:10 ` René Scharfe
2017-12-08 21:11 ` Jeff King
2017-12-07 21:47 ` Junio C Hamano
2017-12-08 10:14 ` Jeff King
2017-12-08 17:29 ` René Scharfe
2017-12-08 18:37 ` Junio C Hamano
2017-12-08 21:28 ` Jeff King
2017-12-18 19:18 ` René Scharfe
2017-12-19 11:38 ` Jeff King
2017-12-19 18:26 ` René Scharfe
2017-12-20 13:05 ` Jeff King [this message]
2017-12-08 21:17 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220130501.GC17569@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).