From: Todd Zullinger <tmz@pobox.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johan Herland <johan@herland.net>,
git@vger.kernel.org, Santiago Torres <santiago@nyu.edu>
Subject: Re: [PATCH] t/lib-gpg: fix gpgconf stderr redirect to /dev/null
Date: Tue, 14 Nov 2017 00:15:20 -0500 [thread overview]
Message-ID: <20171114051520.GU5144@zaya.teonanacatl.net> (raw)
In-Reply-To: <xmqqshdh5ygy.fsf@gitster.mtv.corp.google.com>
Junio C Hamano wrote:
> The message goes to the standard output stream since it was
> introduced in 809f38c8 ("git notes merge: Manual conflict
> resolution, part 1/2", 2010-11-09) and 6abb3655 ("git notes merge:
> Manual conflict resolution, part 2/2", 2010-11-09). I do think it
> makes more sense to send it to the standard error stream, but just
> in case if the original author thinks of a reason why it shouldn't,
> let's summon Johan and ask his input.
Sounds like a good plan. If the message does move to stderr, there
are also a few tests in 3310 that need adjusted. They presume an
error message from `git notes merge`, but they only redirect stdout to
the output file.
While I was bored, I prepared a commit with these changes and
confirmed the test suite passes, in case we get an ACK from Johan.
--
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
It is impossible to enjoy idling thoroughly unless one has plenty of
work to do.
-- Jerome K. Jerome
next prev parent reply other threads:[~2017-11-14 5:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 21:07 [PATCH] t/lib-gpg: fix gpgconf stderr redirect to /dev/null Todd Zullinger
2017-11-13 22:18 ` Santiago Torres
2017-11-13 22:43 ` Todd Zullinger
2017-11-13 23:02 ` Santiago Torres
2017-11-13 23:06 ` Santiago Torres
2017-11-14 3:10 ` Todd Zullinger
2017-11-14 15:35 ` Santiago Torres
2017-11-14 2:49 ` Junio C Hamano
2017-11-14 3:03 ` Todd Zullinger
2017-11-14 3:30 ` Junio C Hamano
2017-11-14 5:15 ` Todd Zullinger [this message]
2017-11-14 9:31 ` Johan Herland
2017-11-14 14:52 ` Junio C Hamano
2017-11-14 16:17 ` [PATCH] notes: send "Automatic notes merge failed" messages to stderr Todd Zullinger
2017-11-15 13:13 ` Johan Herland
2017-11-15 21:09 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114051520.GU5144@zaya.teonanacatl.net \
--to=tmz@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=santiago@nyu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).