From: Johan Herland <johan@herland.net>
To: Todd Zullinger <tmz@pobox.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Santiago Torres <santiago@nyu.edu>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] notes: send "Automatic notes merge failed" messages to stderr
Date: Wed, 15 Nov 2017 14:13:03 +0100 [thread overview]
Message-ID: <CALKQrgfs9QNg9AcQ_CGq43XkSpAAgS4L0KokpCj2qnhPa9+-=w@mail.gmail.com> (raw)
In-Reply-To: <20171114161752.13204-1-tmz@pobox.com>
On Tue, Nov 14, 2017 at 5:17 PM, Todd Zullinger <tmz@pobox.com> wrote:
> All other error messages from notes use stderr. Do the same when
> alerting users of an unresolved notes merge.
>
> Fix the output redirection in t3310 and t3320 as well. Previously, the
> tests directed output to a file, but stderr was either not captured or
> not sent to the file due to the order of the redirection operators.
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
Looks good to me.
...Johan
next prev parent reply other threads:[~2017-11-15 13:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 21:07 [PATCH] t/lib-gpg: fix gpgconf stderr redirect to /dev/null Todd Zullinger
2017-11-13 22:18 ` Santiago Torres
2017-11-13 22:43 ` Todd Zullinger
2017-11-13 23:02 ` Santiago Torres
2017-11-13 23:06 ` Santiago Torres
2017-11-14 3:10 ` Todd Zullinger
2017-11-14 15:35 ` Santiago Torres
2017-11-14 2:49 ` Junio C Hamano
2017-11-14 3:03 ` Todd Zullinger
2017-11-14 3:30 ` Junio C Hamano
2017-11-14 5:15 ` Todd Zullinger
2017-11-14 9:31 ` Johan Herland
2017-11-14 14:52 ` Junio C Hamano
2017-11-14 16:17 ` [PATCH] notes: send "Automatic notes merge failed" messages to stderr Todd Zullinger
2017-11-15 13:13 ` Johan Herland [this message]
2017-11-15 21:09 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALKQrgfs9QNg9AcQ_CGq43XkSpAAgS4L0KokpCj2qnhPa9+-=w@mail.gmail.com' \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=santiago@nyu.edu \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).