git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* git add -p stops working when setting color.ui = always
@ 2017-10-02 10:38 Tsvi Mostovicz
  2017-10-02 18:54 ` Thomas Gummerer
  2017-10-03 19:36 ` Kevin Daudt
  0 siblings, 2 replies; 3+ messages in thread
From: Tsvi Mostovicz @ 2017-10-02 10:38 UTC (permalink / raw)
  To: git

Hi,

When setting "color.ui = always" in the last few versions (not sure
exactly when this started, but definitely exists in 2.14.1 and
2.14.2), git add -p stops working as expected. Instead of prompting
the user, it skips through the prompts and doesn't allow selecting a
hunk.

Don't know why I had color.ui = always set in my .gitconfig.

git version 2.14.2.666.gea220ee40

Thanks,


Tsvi Mostovicz
ttmost@gmail.com
www.linkedin.com/in/tsvim

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git add -p stops working when setting color.ui = always
  2017-10-02 10:38 git add -p stops working when setting color.ui = always Tsvi Mostovicz
@ 2017-10-02 18:54 ` Thomas Gummerer
  2017-10-03 19:36 ` Kevin Daudt
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Gummerer @ 2017-10-02 18:54 UTC (permalink / raw)
  To: Tsvi Mostovicz; +Cc: git

Hi,

On 10/02, Tsvi Mostovicz wrote:
> Hi,
> 
> When setting "color.ui = always" in the last few versions (not sure
> exactly when this started, but definitely exists in 2.14.1 and
> 2.14.2), git add -p stops working as expected. Instead of prompting
> the user, it skips through the prompts and doesn't allow selecting a
> hunk.

This is a known change in behaviour (for more information see the
thread at
https://public-inbox.org/git/86D0A377-8AFD-460D-A90E-6327C6934DFC@gmail.com/).

> 
> Don't know why I had color.ui = always set in my .gitconfig.

Can you set color.ui = auto instead?  That should give you colored
output on the terminal, while not breaking git add -p.

> git version 2.14.2.666.gea220ee40
> 
> Thanks,
> 
> 
> Tsvi Mostovicz
> ttmost@gmail.com
> www.linkedin.com/in/tsvim

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git add -p stops working when setting color.ui = always
  2017-10-02 10:38 git add -p stops working when setting color.ui = always Tsvi Mostovicz
  2017-10-02 18:54 ` Thomas Gummerer
@ 2017-10-03 19:36 ` Kevin Daudt
  1 sibling, 0 replies; 3+ messages in thread
From: Kevin Daudt @ 2017-10-03 19:36 UTC (permalink / raw)
  To: Tsvi Mostovicz; +Cc: git

On Mon, Oct 02, 2017 at 01:38:17PM +0300, Tsvi Mostovicz wrote:
> Hi,
> 
> When setting "color.ui = always" in the last few versions (not sure
> exactly when this started, but definitely exists in 2.14.1 and
> 2.14.2), git add -p stops working as expected. Instead of prompting
> the user, it skips through the prompts and doesn't allow selecting a
> hunk.
> 
> Don't know why I had color.ui = always set in my .gitconfig.
> 
> git version 2.14.2.666.gea220ee40
> 
> Thanks,
> 

Hello Tsvi,

This is being discussed just now[0]. Setting the value to auto should
fix it (setting it to always does not make much sense in your config
file).

Kevin.

[0}:https://public-inbox.org/git/20171003093157.gq7za2fwcqsouire@sigill.intra.peff.net/T/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-03 19:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-02 10:38 git add -p stops working when setting color.ui = always Tsvi Mostovicz
2017-10-02 18:54 ` Thomas Gummerer
2017-10-03 19:36 ` Kevin Daudt

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).