From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: peff@peff.net, git@vger.kernel.org, gitster@pobox.com,
torvalds@linux-foundation.org
Subject: Re: [PATCH] diff: correct newline in summary for renamed files
Date: Wed, 27 Sep 2017 16:15:16 -0700 [thread overview]
Message-ID: <20170927231516.GG19555@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20170927225126.4836-1-sbeller@google.com>
Stefan Beller wrote:
> In 146fdb0dfe (diff.c: emit_diff_symbol learns about DIFF_SYMBOL_SUMMARY,
> 2017-06-29), the conversion from direct printing to the symbol emission
> dropped the new line character for renamed, copied and rewritten files.
>
> Add the emission of a newline, add a test for this case.
>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Helped-by: Jeff King <peff@peff.net>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> diff.c | 1 +
> t/t4013-diff-various.sh | 12 ++++++++++++
> t/t4013/diff.diff-tree_--stat_initial_mode | 4 ++++
> t/t4013/diff.diff-tree_--summary_initial_mode | 3 +++
> t/t4013/diff.diff-tree_initial_mode | 3 +++
> t/t4013/diff.log_--decorate=full_--all | 6 ++++++
> t/t4013/diff.log_--decorate_--all | 6 ++++++
> 7 files changed, 35 insertions(+)
> create mode 100644 t/t4013/diff.diff-tree_--stat_initial_mode
> create mode 100644 t/t4013/diff.diff-tree_--summary_initial_mode
> create mode 100644 t/t4013/diff.diff-tree_initial_mode
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
next prev parent reply other threads:[~2017-09-27 23:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 18:15 diffstat summary mode change bug Linus Torvalds
2017-09-27 20:40 ` Stefan Beller
2017-09-27 21:02 ` Linus Torvalds
2017-09-27 21:09 ` Stefan Beller
2017-09-27 21:58 ` [PATCH] diff: correct newline in summary for renamed files Stefan Beller
2017-09-27 22:04 ` Linus Torvalds
2017-09-27 22:09 ` Jeff King
2017-09-27 22:32 ` Jeff King
2017-09-27 22:39 ` Stefan Beller
2017-09-27 22:49 ` Jeff King
2017-09-27 22:51 ` Stefan Beller
2017-09-27 23:15 ` Jonathan Nieder [this message]
2017-09-27 23:49 ` Ramsay Jones
2017-09-27 23:57 ` Stefan Beller
2017-09-28 0:39 ` Jeff King
2017-09-28 4:14 ` Junio C Hamano
2017-09-28 0:35 ` Jeff King
2017-09-27 22:34 ` Stefan Beller
2017-09-28 4:12 ` diffstat summary mode change bug Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927231516.GG19555@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).