From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] diff: correct newline in summary for renamed files
Date: Wed, 27 Sep 2017 18:49:10 -0400 [thread overview]
Message-ID: <20170927224909.25dfojhx6wzaqwt7@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kYAfii=vwXwSkx-QE+tXSfPE5h1c39gZSB=c5Asfq9P3Q@mail.gmail.com>
On Wed, Sep 27, 2017 at 03:39:00PM -0700, Stefan Beller wrote:
> On Wed, Sep 27, 2017 at 3:32 PM, Jeff King <peff@peff.net> wrote:
>
> > The most appropriate place seems like t4013. I tried adding to its big
> > list of tested formats, but it's quite fragile. The patch below is what
> > I came up with, but it still needs updated to cover the cases which call
> > "log --all".
> >
> > I think we'd do better to just do a set of new tests at the end (or even
> > a new test script for diffing mode changes in various formats).
>
> Thanks for providing this patch, I think it is actually reasonable to
> do it here. I can fixup the rest if you don't mind.
OK. Please go ahead, then.
-Peff
next prev parent reply other threads:[~2017-09-27 22:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 18:15 diffstat summary mode change bug Linus Torvalds
2017-09-27 20:40 ` Stefan Beller
2017-09-27 21:02 ` Linus Torvalds
2017-09-27 21:09 ` Stefan Beller
2017-09-27 21:58 ` [PATCH] diff: correct newline in summary for renamed files Stefan Beller
2017-09-27 22:04 ` Linus Torvalds
2017-09-27 22:09 ` Jeff King
2017-09-27 22:32 ` Jeff King
2017-09-27 22:39 ` Stefan Beller
2017-09-27 22:49 ` Jeff King [this message]
2017-09-27 22:51 ` Stefan Beller
2017-09-27 23:15 ` Jonathan Nieder
2017-09-27 23:49 ` Ramsay Jones
2017-09-27 23:57 ` Stefan Beller
2017-09-28 0:39 ` Jeff King
2017-09-28 4:14 ` Junio C Hamano
2017-09-28 0:35 ` Jeff King
2017-09-27 22:34 ` Stefan Beller
2017-09-28 4:12 ` diffstat summary mode change bug Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927224909.25dfojhx6wzaqwt7@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).