From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/7] read_in_full: reset errno before reading
Date: Mon, 25 Sep 2017 19:45:41 -0400 [thread overview]
Message-ID: <20170925234541.l6qcislhfwtnxf5m@sigill.intra.peff.net> (raw)
In-Reply-To: <20170925233732.4lqavl56qwpfjuxy@sigill.intra.peff.net>
On Mon, Sep 25, 2017 at 07:37:32PM -0400, Jeff King wrote:
> > Correct. Actually more than "frown on": except for with the few calls
> > like strtoul that are advertised to work this way, POSIX does not make
> > the guarantee the above code would rely on, at all.
> >
> > So it's not just frowned upon: it's so unportable that the standard
> > calls it out as something that won't work.
>
> Is it unportable? Certainly read() is free reset errno to zero on
> success. But is it allowed to set it to another random value?
>
> I think we're getting pretty academic here, but I'm curious if you have
> a good reference.
Answering my own question. POSIX says:
No function in this volume of IEEE Std 1003.1-2001 shall set errno to
0. The setting of errno after a successful call to a function is
unspecified unless the description of that function specifies that
errno shall not be modified.
So that does seem to outlaw errno-only checks for most functions.
It makes me wonder if the recent getdelim() fix is technically violating
this. It should instead be explicitly checking for feof().
> IMHO as long as it _is_ deterministic and recognize as not an error from
> read(), that's the best we can do. Which is why I went with "0" in the
> first place. Seeing "read error: success" is a common-ish idiom (to me
> anyway) for "read didn't fail, but some user-space logic did", if only
> because it often happens accidentally.
Another option I ran across from POSIX:
[EOVERFLOW]
The file is a regular file, nbyte is greater than 0, the starting
position is before the end-of-file, and the starting position is
greater than or equal to the offset maximum established in the open
file description associated with fildes.
That's not _exactly_ what's going on here, but it's pretty close. And is
what you would get if you implemented read_exactly() in terms of
something like pread().
-Peff
next prev parent reply other threads:[~2017-09-25 23:45 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 20:26 [PATCH 0/7] read/write_in_full leftovers Jeff King
2017-09-25 20:27 ` [PATCH 1/7] files-backend: prefer "0" for write_in_full() error check Jeff King
2017-09-25 21:59 ` Jonathan Nieder
2017-09-25 23:13 ` Jeff King
2017-09-25 20:27 ` [PATCH 2/7] notes-merge: drop dead zero-write code Jeff King
2017-09-25 21:59 ` Jonathan Nieder
2017-09-25 20:29 ` [PATCH 3/7] read_in_full: reset errno before reading Jeff King
2017-09-25 22:09 ` Jonathan Nieder
2017-09-25 23:23 ` Jeff King
2017-09-25 23:33 ` Jonathan Nieder
2017-09-25 23:37 ` Jeff King
2017-09-25 23:45 ` Jeff King [this message]
2017-09-25 23:55 ` Jonathan Nieder
2017-09-26 0:01 ` Jeff King
2017-09-26 0:06 ` Stefan Beller
2017-09-26 0:09 ` Jeff King
2017-09-26 0:16 ` Jonathan Nieder
2017-09-26 0:17 ` Jonathan Nieder
2017-09-26 0:19 ` Jeff King
2017-09-26 0:22 ` Jonathan Nieder
2017-09-26 4:11 ` Junio C Hamano
2017-09-27 4:07 ` Jeff King
2017-09-27 4:27 ` Junio C Hamano
2017-09-26 0:13 ` Jonathan Nieder
2017-09-26 0:17 ` Jeff King
2017-09-26 0:20 ` Jonathan Nieder
2017-09-26 0:25 ` Jeff King
2017-09-26 0:28 ` Jonathan Nieder
2017-09-25 23:52 ` Jonathan Nieder
2017-09-25 20:29 ` [PATCH 4/7] get-tar-commit-id: prefer "!=" for read_in_full() error check Jeff King
2017-09-25 22:10 ` Jonathan Nieder
2017-09-25 20:30 ` [PATCH 5/7] worktree: use xsize_t to access file size Jeff King
2017-09-25 22:11 ` Jonathan Nieder
2017-09-25 20:31 ` [PATCH 6/7] worktree: check the result of read_in_full() Jeff King
2017-09-25 22:14 ` Jonathan Nieder
2017-09-25 23:25 ` Jeff King
2017-09-25 20:33 ` [PATCH 7/7] add xread_in_full() helper Jeff King
2017-09-25 22:16 ` Jonathan Nieder
2017-09-25 23:27 ` Jeff King
2017-09-27 5:54 ` [PATCH v2 0/7] read/write_in_full leftovers Jeff King
2017-09-27 6:00 ` [PATCH v2 1/7] files-backend: prefer "0" for write_in_full() error check Jeff King
2017-09-27 6:00 ` [PATCH v2 2/7] notes-merge: drop dead zero-write code Jeff King
2017-09-27 6:00 ` [PATCH v2 3/7] prefer "!=" when checking read_in_full() result Jeff King
2017-09-27 6:59 ` Junio C Hamano
2017-09-27 7:09 ` Jeff King
2017-09-27 6:01 ` [PATCH v2 4/7] avoid looking at errno for short read_in_full() returns Jeff King
2017-09-27 6:59 ` Junio C Hamano
2017-09-27 6:02 ` [PATCH v2 5/7] distinguish error versus short read from read_in_full() Jeff King
2017-09-27 6:02 ` [PATCH v2 6/7] worktree: use xsize_t to access file size Jeff King
2017-09-27 6:02 ` [PATCH v2 7/7] worktree: check the result of read_in_full() Jeff King
2017-09-27 6:57 ` [PATCH v2 0/7] read/write_in_full leftovers Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925234541.l6qcislhfwtnxf5m@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).