From: Stefan Beller <sbeller@google.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, jrnieder@gmail.com, sbeller@google.com
Subject: [PATCH] Documentation: consolidate submodule.<name>.update
Date: Mon, 25 Sep 2017 12:10:11 -0700 [thread overview]
Message-ID: <20170925191011.29863-1-sbeller@google.com> (raw)
In-Reply-To: <xmqq1smxj7md.fsf@gitster.mtv.corp.google.com>
Have one place to explain the effects of setting submodule.<name>.update
instead of two.
Signed-off-by: Stefan Beller <sbeller@google.com>
---
>> I disagree. Actually, I think the git-config(1) blurb could just
>> point here, and that the text here ought to be clear about what
>> commands it affects and how an end user would use it.
>
> I tend to agree with the consolidation.
Something like this?
Documentation/config.txt | 9 +--------
Documentation/gitmodules.txt | 20 +++++++++++---------
2 files changed, 12 insertions(+), 17 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index 1ac0ae6adb..0d5a296b6c 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -3085,14 +3085,7 @@ submodule.<name>.url::
See linkgit:git-submodule[1] and linkgit:gitmodules[5] for details.
submodule.<name>.update::
- The method by which a submodule is updated by 'git submodule update',
- which is the only affected command, others such as
- 'git checkout --recurse-submodules' are unaffected. It exists for
- historical reasons, when 'git submodule' was the only command to
- interact with submodules; settings like `submodule.active`
- and `pull.rebase` are more specific. It is populated by
- `git submodule init` from the linkgit:gitmodules[5] file.
- See description of 'update' command in linkgit:git-submodule[1].
+ See `submodule.<name>.update` in linkgit:gitmodules[5].
submodule.<name>.branch::
The remote branch name for a submodule, used by `git submodule
diff --git a/Documentation/gitmodules.txt b/Documentation/gitmodules.txt
index db5d47eb19..d156dee387 100644
--- a/Documentation/gitmodules.txt
+++ b/Documentation/gitmodules.txt
@@ -38,15 +38,17 @@ submodule.<name>.url::
In addition, there are a number of optional keys:
submodule.<name>.update::
- Defines the default update procedure for the named submodule,
- i.e. how the submodule is updated by "git submodule update"
- command in the superproject. This is only used by `git
- submodule init` to initialize the configuration variable of
- the same name. Allowed values here are 'checkout', 'rebase',
- 'merge' or 'none'. See description of 'update' command in
- linkgit:git-submodule[1] for their meaning. Note that the
- '!command' form is intentionally ignored here for security
- reasons.
+ The method by which a submodule is updated by 'git submodule update',
+ which is the only affected command, others such as
+ 'git checkout --recurse-submodules' are unaffected. It exists for
+ historical reasons, when 'git submodule' was the only command to
+ interact with submodules; settings like `submodule.active`
+ and `pull.rebase` are more specific. It is copied to the config
+ by `git submodule init` from the .gitmodules file.
+ Allowed values here are 'checkout', 'rebase', 'merge' or 'none'.
+ See description of 'update' command in linkgit:git-submodule[1]
+ for their meaning. Note that the '!command' form is intentionally
+ ignored here for security reasons.
submodule.<name>.branch::
A remote branch name for tracking updates in the upstream submodule.
--
2.14.0.rc0.3.g6c2e499285
next prev parent reply other threads:[~2017-09-25 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 21:28 [PATCH] Documentation/config: clarify the meaning of submodule.<name>.update Stefan Beller
2017-09-22 21:37 ` Jonathan Nieder
2017-09-22 22:52 ` [PATCHv2] " Stefan Beller
2017-09-22 22:58 ` Jonathan Nieder
2017-09-23 23:52 ` Junio C Hamano
2017-09-25 19:10 ` Stefan Beller [this message]
2017-09-25 19:17 ` [PATCH] Documentation: consolidate submodule.<name>.update Brandon Williams
2017-09-25 22:18 ` Stefan Beller
2017-09-25 22:22 ` Jonathan Nieder
2017-09-25 22:42 ` Stefan Beller
2017-09-25 23:44 ` Jonathan Nieder
2017-09-26 1:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925191011.29863-1-sbeller@google.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).