From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: Brandon Williams <bmwill@google.com>,
Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] Documentation: consolidate submodule.<name>.update
Date: Mon, 25 Sep 2017 16:44:28 -0700 [thread overview]
Message-ID: <20170925234428.GJ27425@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kY4tAfYERj1V2AL+piqWe6nw0qA+AHqm5w6ch9WiL86pw@mail.gmail.com>
Stefan Beller wrote:
> By as-is I refer to origin/pu.
Ah, okay. I'm not in that habit because pu frequently loses topics
--- it's mostly useful as a tool to (1) distribute topic branches and
(2) check whether they are compatible with each other.
[...]
> On Mon, Sep 25, 2017 at 3:22 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Maybe we should work on first wordsmithing the doc and then figuring
>> out where it goes? The current state of the doc with (?) three
>> different texts,
>
> such that each different text highlights each locations purpose.
>
>> all wrong,
>
> Care to spell out this bold claim?
In the state of "master", "man git-config" tells me that
[submodule "<name>"]
update = ...
sets the "default update procedure for a submodule". It suggests that
I read about "git submodule update" in git-submodule(1) for more
details. This is problematic because
1. It doesn't tell me when I should and should not set it.
2. I would expect "git checkout --recurse-submodules" to respect the
default update procedure.
3. It doesn't tell me what commands like "git fetch
--recurse-submodules" will do.
4. It doesn't point me to better alternatives, when this
configuration doesn't fit my use case.
"man git-submodule" doesn't have a section on submodule.<name>.update.
It has references scattered throughout the manpage. It only tells me
how the setting affects the "git submodule update" command and doesn't
address the problems (1)-(4).
"man gitmodules" also refers to this setting as the "default update
procedure for the named submodule". It doesn't answer the questions
(1)-(4) either.
Thanks and hope that helps,
Jonathan
next prev parent reply other threads:[~2017-09-25 23:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 21:28 [PATCH] Documentation/config: clarify the meaning of submodule.<name>.update Stefan Beller
2017-09-22 21:37 ` Jonathan Nieder
2017-09-22 22:52 ` [PATCHv2] " Stefan Beller
2017-09-22 22:58 ` Jonathan Nieder
2017-09-23 23:52 ` Junio C Hamano
2017-09-25 19:10 ` [PATCH] Documentation: consolidate submodule.<name>.update Stefan Beller
2017-09-25 19:17 ` Brandon Williams
2017-09-25 22:18 ` Stefan Beller
2017-09-25 22:22 ` Jonathan Nieder
2017-09-25 22:42 ` Stefan Beller
2017-09-25 23:44 ` Jonathan Nieder [this message]
2017-09-26 1:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925234428.GJ27425@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).