From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 3/4] cache.h: hex2chr() - avoid -Wsign-compare warnings
Date: Fri, 22 Sep 2017 12:22:51 -0400 [thread overview]
Message-ID: <20170922162251.kx2w5u4falztcpnh@sigill.intra.peff.net> (raw)
In-Reply-To: <20170922161817.iy5tpexouxn5uwsb@sigill.intra.peff.net>
On Fri, Sep 22, 2017 at 12:18:17PM -0400, Jeff King wrote:
> > I think if this function is fed an empty string that it will also read
> > past the end of the buffer for in[1]. It shouldn't matter, since the NUL
> > in in[0] would cause us to return an error regardless, but it's still
> > undefined behavior.
>
> This is still a bug, though.
Last message, I promise. ;)
I started on the minimal fix for this, but actually it's OK by virtue of
its sole caller first checking that we have enough length (because we're
not parsing a string, in fact, but a ptr/len buffer).
So all is well, though I think get_hex_color() does serve as a poor
example if somebody were to try to adapt it generally (hopefully they
wouldn't, since hex2chr() is already globally available).
Sorry for the all the noise.
-Peff
next prev parent reply other threads:[~2017-09-22 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 16:48 [PATCH 3/4] cache.h: hex2chr() - avoid -Wsign-compare warnings Ramsay Jones
2017-09-22 5:47 ` Jeff King
2017-09-22 16:05 ` Ramsay Jones
2017-09-22 16:11 ` Jeff King
2017-09-22 16:18 ` Jeff King
2017-09-22 16:22 ` Jeff King [this message]
2017-09-22 16:24 ` Ramsay Jones
2017-09-22 18:01 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922162251.kx2w5u4falztcpnh@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).