* [PATCH] clone: teach recursive clones to respect -q
@ 2017-08-03 22:25 Brandon Williams
2017-08-03 22:32 ` Stefan Beller
2017-08-04 16:07 ` Junio C Hamano
0 siblings, 2 replies; 4+ messages in thread
From: Brandon Williams @ 2017-08-03 22:25 UTC (permalink / raw)
To: git; +Cc: Brandon Williams
Teach 'git clone --recurse-submodules' to respect the '-q' option by
passing down the quiet flag to the process which handles cloning of
submodules.
Signed-off-by: Brandon Williams <bmwill@google.com>
---
builtin/clone.c | 3 +++
t/t7400-submodule-basic.sh | 6 ++++++
2 files changed, 9 insertions(+)
diff --git a/builtin/clone.c b/builtin/clone.c
index 08b5cc433..f7e17d229 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -768,6 +768,9 @@ static int checkout(int submodule_progress)
if (submodule_progress)
argv_array_push(&args, "--progress");
+ if (option_verbosity < 0)
+ argv_array_push(&args, "--quiet");
+
err = run_command_v_opt(args.argv, RUN_GIT_CMD);
argv_array_clear(&args);
}
diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
index dcac364c5..e9c3335b7 100755
--- a/t/t7400-submodule-basic.sh
+++ b/t/t7400-submodule-basic.sh
@@ -1289,4 +1289,10 @@ test_expect_success 'init properly sets the config' '
test_must_fail git -C multisuper_clone config --get submodule.sub1.active
'
+test_expect_success 'recursive clone respects -q' '
+ test_when_finished "rm -rf multisuper_clone" &&
+ git clone -q --recurse-submodules multisuper multisuper_clone >actual &&
+ test_must_be_empty actual
+'
+
test_done
--
2.14.0.rc1.383.gd1ce394fe2-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clone: teach recursive clones to respect -q
2017-08-03 22:25 [PATCH] clone: teach recursive clones to respect -q Brandon Williams
@ 2017-08-03 22:32 ` Stefan Beller
2017-08-04 16:07 ` Junio C Hamano
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Beller @ 2017-08-03 22:32 UTC (permalink / raw)
To: Brandon Williams; +Cc: git@vger.kernel.org
On Thu, Aug 3, 2017 at 3:25 PM, Brandon Williams <bmwill@google.com> wrote:
> Teach 'git clone --recurse-submodules' to respect the '-q' option by
> passing down the quiet flag to the process which handles cloning of
> submodules.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
Yay! Thanks for this.
Looks good to me.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clone: teach recursive clones to respect -q
2017-08-03 22:25 [PATCH] clone: teach recursive clones to respect -q Brandon Williams
2017-08-03 22:32 ` Stefan Beller
@ 2017-08-04 16:07 ` Junio C Hamano
2017-08-04 17:05 ` Brandon Williams
1 sibling, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2017-08-04 16:07 UTC (permalink / raw)
To: Brandon Williams; +Cc: git
Brandon Williams <bmwill@google.com> writes:
> Teach 'git clone --recurse-submodules' to respect the '-q' option by
> passing down the quiet flag to the process which handles cloning of
> submodules.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
> builtin/clone.c | 3 +++
> t/t7400-submodule-basic.sh | 6 ++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/builtin/clone.c b/builtin/clone.c
> index 08b5cc433..f7e17d229 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -768,6 +768,9 @@ static int checkout(int submodule_progress)
> if (submodule_progress)
> argv_array_push(&args, "--progress");
>
> + if (option_verbosity < 0)
> + argv_array_push(&args, "--quiet");
> +
> err = run_command_v_opt(args.argv, RUN_GIT_CMD);
> argv_array_clear(&args);
> }
Good spotting. Makes me wonder if there still are other options we
might have missed, but we can incrementally improve as bug report
comes in ;-)
Will queue. Thanks.
> diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
> index dcac364c5..e9c3335b7 100755
> --- a/t/t7400-submodule-basic.sh
> +++ b/t/t7400-submodule-basic.sh
> @@ -1289,4 +1289,10 @@ test_expect_success 'init properly sets the config' '
> test_must_fail git -C multisuper_clone config --get submodule.sub1.active
> '
>
> +test_expect_success 'recursive clone respects -q' '
> + test_when_finished "rm -rf multisuper_clone" &&
> + git clone -q --recurse-submodules multisuper multisuper_clone >actual &&
> + test_must_be_empty actual
> +'
> +
> test_done
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clone: teach recursive clones to respect -q
2017-08-04 16:07 ` Junio C Hamano
@ 2017-08-04 17:05 ` Brandon Williams
0 siblings, 0 replies; 4+ messages in thread
From: Brandon Williams @ 2017-08-04 17:05 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On 08/04, Junio C Hamano wrote:
> Brandon Williams <bmwill@google.com> writes:
>
> > Teach 'git clone --recurse-submodules' to respect the '-q' option by
> > passing down the quiet flag to the process which handles cloning of
> > submodules.
> >
> > Signed-off-by: Brandon Williams <bmwill@google.com>
> > ---
> > builtin/clone.c | 3 +++
> > t/t7400-submodule-basic.sh | 6 ++++++
> > 2 files changed, 9 insertions(+)
> >
> > diff --git a/builtin/clone.c b/builtin/clone.c
> > index 08b5cc433..f7e17d229 100644
> > --- a/builtin/clone.c
> > +++ b/builtin/clone.c
> > @@ -768,6 +768,9 @@ static int checkout(int submodule_progress)
> > if (submodule_progress)
> > argv_array_push(&args, "--progress");
> >
> > + if (option_verbosity < 0)
> > + argv_array_push(&args, "--quiet");
> > +
> > err = run_command_v_opt(args.argv, RUN_GIT_CMD);
> > argv_array_clear(&args);
> > }
>
> Good spotting. Makes me wonder if there still are other options we
> might have missed, but we can incrementally improve as bug report
> comes in ;-)
Yeah I've noticed that the number one difficulty with doing submodule
operations in another process is making sure that the correct options
are passed down.
>
> Will queue. Thanks.
Thanks!
>
> > diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
> > index dcac364c5..e9c3335b7 100755
> > --- a/t/t7400-submodule-basic.sh
> > +++ b/t/t7400-submodule-basic.sh
> > @@ -1289,4 +1289,10 @@ test_expect_success 'init properly sets the config' '
> > test_must_fail git -C multisuper_clone config --get submodule.sub1.active
> > '
> >
> > +test_expect_success 'recursive clone respects -q' '
> > + test_when_finished "rm -rf multisuper_clone" &&
> > + git clone -q --recurse-submodules multisuper multisuper_clone >actual &&
> > + test_must_be_empty actual
> > +'
> > +
> > test_done
--
Brandon Williams
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-04 17:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-03 22:25 [PATCH] clone: teach recursive clones to respect -q Brandon Williams
2017-08-03 22:32 ` Stefan Beller
2017-08-04 16:07 ` Junio C Hamano
2017-08-04 17:05 ` Brandon Williams
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).