git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Tan <jonathantanmy@google.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: git@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	peff@peff.net, gitster@pobox.com
Subject: Re: [PATCH 2/3] trailers: export action enums and corresponding lookup functions
Date: Wed, 12 Jul 2017 14:13:51 -0700	[thread overview]
Message-ID: <20170712141351.73a8ea60@twelve2.svl.corp.google.com> (raw)
In-Reply-To: <20170712134646.17179-3-bonzini@gnu.org>

On Wed, 12 Jul 2017 15:46:45 +0200
Paolo Bonzini <bonzini@gnu.org> wrote:

> -static struct conf_info default_conf_info;
> +static struct conf_info default_conf_info = {
> +	.where = WHERE_END,
> +	.if_exists = EXISTS_ADD_IF_DIFFERENT_NEIGHBOR,
> +	.if_missing = MISSING_ADD,
> +};

I'm not sure if Git is ready to commit to using designated initializers,
so maybe avoid those for now. More information here [1].

[1] https://public-inbox.org/git/20170710070342.txmlwwq6gvjkwtw7@sigill.intra.peff.net/

  reply	other threads:[~2017-07-12 21:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12 13:46 [PATCH 0/3] interpret-trailers: add --where, --if-exists, --if-missing Paolo Bonzini
2017-07-12 13:46 ` [PATCH 1/3] trailers: create struct trailer_opts Paolo Bonzini
2017-07-12 21:19   ` Jonathan Tan
2017-07-12 13:46 ` [PATCH 2/3] trailers: export action enums and corresponding lookup functions Paolo Bonzini
2017-07-12 21:13   ` Jonathan Tan [this message]
2017-07-12 13:46 ` [PATCH 3/3] interpret-trailers: add options for actions Paolo Bonzini
2017-07-12 21:10   ` Jonathan Tan
2017-07-12 21:33     ` Paolo Bonzini
2017-07-12 14:47 ` [PATCH 0/3] interpret-trailers: add --where, --if-exists, --if-missing Christian Couder
2017-07-12 15:02   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170712141351.73a8ea60@twelve2.svl.corp.google.com \
    --to=jonathantanmy@google.com \
    --cc=bonzini@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pbonzini@redhat.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).