From: Paolo Bonzini <bonzini@gnu.org>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 3/3] interpret-trailers: add options for actions
Date: Wed, 12 Jul 2017 23:33:59 +0200 [thread overview]
Message-ID: <02354996-dccc-b2fb-a3b5-aa819229caa0@gnu.org> (raw)
In-Reply-To: <20170712141028.2d6beecc@twelve2.svl.corp.google.com>
On 12/07/2017 23:10, Jonathan Tan wrote:
> When I would expect the last 2 commands to produce the same output. Maybe
> invoke set_where(where, NULL) when "unset" is true? And change set_where()
> accordingly. Same for the other two option parsing functions.
Sounds good, and I'll also add a test case of course.
In fact arg is already NULL if unset is true, so the code of the three
option parsing functions becomes simpler.
Thanks!
Paolo
next prev parent reply other threads:[~2017-07-12 21:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 13:46 [PATCH 0/3] interpret-trailers: add --where, --if-exists, --if-missing Paolo Bonzini
2017-07-12 13:46 ` [PATCH 1/3] trailers: create struct trailer_opts Paolo Bonzini
2017-07-12 21:19 ` Jonathan Tan
2017-07-12 13:46 ` [PATCH 2/3] trailers: export action enums and corresponding lookup functions Paolo Bonzini
2017-07-12 21:13 ` Jonathan Tan
2017-07-12 13:46 ` [PATCH 3/3] interpret-trailers: add options for actions Paolo Bonzini
2017-07-12 21:10 ` Jonathan Tan
2017-07-12 21:33 ` Paolo Bonzini [this message]
2017-07-12 14:47 ` [PATCH 0/3] interpret-trailers: add --where, --if-exists, --if-missing Christian Couder
2017-07-12 15:02 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02354996-dccc-b2fb-a3b5-aa819229caa0@gnu.org \
--to=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).