From: "Øyvind A. Holm" <sunny@sunbase.org>
To: Jeff King <peff@peff.net>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
"Git mailing list" <git@vger.kernel.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] configure.ac: loosen FREAD_READS_DIRECTORIES test program
Date: Wed, 14 Jun 2017 12:59:56 +0200 [thread overview]
Message-ID: <20170614105955.aj4rtamzp4yy6g6b@sunbase.org> (raw)
In-Reply-To: <20170614053018.pbeftfyz2md4o73h@sigill.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
On 2017-06-14 01:30:18, Jeff King wrote:
> On Wed, Jun 14, 2017 at 01:15:44AM -0400, Jeff King wrote:
> > Actually, I'm not sure if configure.ac is wrong, or the new uses of
> > FREAD_READS_DIRECTORIES. Because the test configure.ac actually
> > checks:
>
> Poking around more, I think the best thing is to just update the
> configure script. The rationale is below.
>
> -- >8 --
> Subject: [PATCH] configure.ac: loosen FREAD_READS_DIRECTORIES test
> program
Yes, this patch fixes t1308. I also ran the whole test suite with the
patch, everything succeeds.
Thanks,
Øyvind
N 60.376° E 5.3334°
OpenPGP fingerprint: A006 05D6 E676 B319 55E2 E77E FB0C BEE8 94A5 06E5
17e7451e-50f0-11e7-a287-db5caa6d21d3
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2017-06-14 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 1:15 t1308-config-set.sh fails on current master Øyvind A. Holm
2017-06-14 1:25 ` Jonathan Nieder
2017-06-14 2:17 ` Øyvind A. Holm
2017-06-14 5:02 ` Jeff King
2017-06-14 5:15 ` Jeff King
2017-06-14 5:30 ` [PATCH] configure.ac: loosen FREAD_READS_DIRECTORIES test program Jeff King
2017-06-14 10:59 ` Øyvind A. Holm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614105955.aj4rtamzp4yy6g6b@sunbase.org \
--to=sunny@sunbase.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).