From: Jonathan Nieder <jrnieder@gmail.com>
To: "Øyvind A. Holm" <sunny@sunbase.org>,
"Git mailing list" <git@vger.kernel.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: t1308-config-set.sh fails on current master
Date: Tue, 13 Jun 2017 18:25:35 -0700 [thread overview]
Message-ID: <20170614012535.GU133952@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20170614011514.sh4euddp44hjbu4u@sunbase.org>
Hi Øyvind,
Øyvind A. Holm wrote:
> t1308-config-set.sh fails on current master (v2.13.1-449-g02a2850ad58e).
> The error is introduced by commit e2d90fd1c33a ("config.mak.uname: set
> FREAD_READS_DIRECTORIES for Linux and FreeBSD"). Reverting the commit
> results in a conflict, but the test works on the commit before,
> 02912f477586.
>
> Tested on
>
> Debian GNU/Linux 8.8 (jessie)
> Linux Mint 18 Sarah
Interesting. I'm not able to reproduce it, but of course that doesn't
mean much.
> Test output:
>
> $ ./t1308-config-set.sh
> ok 1 - setup default config
> ok 2 - get value for a simple key
> ok 3 - get value for a key with value as an empty string
> ok 4 - get value for a key with value as NULL
> ok 5 - upper case key
> ok 6 - mixed case key
> ok 7 - key and value with mixed case
> ok 8 - key with case sensitive subsection
> ok 9 - key with case insensitive section header
> ok 10 - key with case insensitive section header & variable
> ok 11 - find value with misspelled key
> ok 12 - find value with the highest priority
> ok 13 - find integer value for a key
> ok 14 - find string value for a key
> ok 15 - check line error when NULL string is queried
> ok 16 - find integer if value is non parse-able
> ok 17 - find bool value for the entered key
> ok 18 - find multiple values
> ok 19 - find value from a configset
> ok 20 - find value with highest priority from a configset
> ok 21 - find value_list for a key from a configset
> ok 22 - proper error on non-existent files
> not ok 23 - proper error on directory "files"
> #
> # echo "Error (-1) reading configuration file a-directory." >expect &&
> # mkdir a-directory &&
> # test_expect_code 2 test-config configset_get_value foo.bar a-directory 2>output &&
> # grep "^warning:" output &&
> # grep "^Error" output >actual &&
> # test_cmp expect actual
> #
> ok 24 - proper error on non-accessible files
> ok 25 - proper error on error in default config files
> ok 26 - proper error on error in custom config files
> ok 27 - check line errors for malformed values
> ok 28 - error on modifying repo config without repo
> ok 29 - iteration shows correct origins
> # failed 1 among 29 test(s)
> 1..29
What is the output of the following command?
./t1308-config-set.sh --run=1,23 -x -v -i
Other diagnostics:
- what is the output of "env"?
- cat ../GIT-BUILD-OPTIONS
- if you run that under 'strace -f -o /tmp/strace.out', does the
strace.out say anything interesting?
Thanks,
Jonathan
next prev parent reply other threads:[~2017-06-14 1:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 1:15 t1308-config-set.sh fails on current master Øyvind A. Holm
2017-06-14 1:25 ` Jonathan Nieder [this message]
2017-06-14 2:17 ` Øyvind A. Holm
2017-06-14 5:02 ` Jeff King
2017-06-14 5:15 ` Jeff King
2017-06-14 5:30 ` [PATCH] configure.ac: loosen FREAD_READS_DIRECTORIES test program Jeff King
2017-06-14 10:59 ` Øyvind A. Holm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614012535.GU133952@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=sunny@sunbase.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).