From: Jonathan Nieder <jrnieder@gmail.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: git@vger.kernel.org,
"Dennis Kaarsemaker" <dennis@kaarsemaker.net>,
"Brandon Williams" <bmwill@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] send-email: Net::SMTP::starttls was introduced in v3.01 (Re: [BUG] git-send-email broken: Can't locate object method "starttls")
Date: Wed, 31 May 2017 16:01:56 -0700 [thread overview]
Message-ID: <20170531230156.GE81679@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20170531225708.GE72735@gmail.com>
Eric Biggers wrote:
> On Wed, May 31, 2017 at 03:44:15PM -0700, Jonathan Nieder wrote:
>> Subject: send-email: Net::SMTP::starttls was introduced in v3.01
>>
>> We cannot rely on the starttls method being present in the copy
>> of Net::SMTP shipped with perl until v5.21.5~169 (Update libnet to
>> CPAN version 3.01, 2014-10-10).
>>
>> Reported-by: Brandon Williams <bmwill@google.com>
>> Reported-by: Eric Biggers <ebiggers3@gmail.com>
>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
>> ---
[...]
>> +++ b/git-send-email.perl
>> @@ -1354,7 +1354,7 @@ EOF
>> }
>>
>> require Net::SMTP;
>> - my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("1.28");
>> + my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("3.01");
>> $smtp_domain ||= maildomain();
>>
>> if ($smtp_encryption eq 'ssl') {
>> --
>
> Yes, that solves the problem for me.
Thanks. Mining through https://github.com/gbarr/perl-libnet, I find
$ git log -Sstarttls
[...]
commit b4a7a274a7fe5344c154abc4b3fdd7c446d36370
Author: Steffen Ullrich <Steffen_Ullrich@genua.de>
Date: Fri May 9 23:15:48 2014 +0200
SSL and IPv6 support for Net::SMTP
$ git show b4a7a274a7fe5344c154abc4b3fdd7c446d36370
[...]
diff --git a/Net/SMTP.pm b/Net/SMTP.pm
index 705b5c5..fcc124f 100644
--- a/Net/SMTP.pm
+++ b/Net/SMTP.pm
@@ -18,7 +18,31 @@ use Net::Config;
$VERSION = "2.33";
[...]
$ git log -p --ancestry-path b4a7a274a7fe5344c154abc4b3fdd7c446d36370..HEAD -- Net/SMTP.pm
[...]
commit 67b37d5c7118f9af50e5a5a00c242992caba3b8d
Author: Steve Hay <steve.m.hay@googlemail.com>
Date: Mon Jun 2 14:13:55 2014 +0100
Bump $VERSION in changed modules
diff --git a/Net/SMTP.pm b/Net/SMTP.pm
index 4496f6f..9dfaadf 100644
--- a/Net/SMTP.pm
+++ b/Net/SMTP.pm
@@ -16,7 +16,7 @@ use IO::Socket;
use Net::Cmd;
use Net::Config;
-$VERSION = "2.34";
+$VERSION = "2.35";
# Code for detecting if we can use SSL
my $ssl_class = eval {
I think 2.35 is the correct minimum version.
Jonathan
next prev parent reply other threads:[~2017-05-31 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 22:24 [BUG] git-send-email broken: Can't locate object method "starttls" Eric Biggers
2017-05-31 22:44 ` [PATCH] send-email: Net::SMTP::starttls was introduced in v3.01 (Re: [BUG] git-send-email broken: Can't locate object method "starttls") Jonathan Nieder
2017-05-31 22:51 ` Junio C Hamano
2017-05-31 22:57 ` Eric Biggers
2017-05-31 23:01 ` Jonathan Nieder [this message]
2017-06-01 0:17 ` [PATCH v2] send-email: Net::SMTP::starttls was introduced in v2.34 " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531230156.GE81679@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=dennis@kaarsemaker.net \
--cc=ebiggers3@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).