From: Eric Biggers <ebiggers3@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org,
"Dennis Kaarsemaker" <dennis@kaarsemaker.net>,
"Brandon Williams" <bmwill@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] send-email: Net::SMTP::starttls was introduced in v3.01 (Re: [BUG] git-send-email broken: Can't locate object method "starttls")
Date: Wed, 31 May 2017 15:57:08 -0700 [thread overview]
Message-ID: <20170531225708.GE72735@gmail.com> (raw)
In-Reply-To: <20170531224415.GC81679@aiede.mtv.corp.google.com>
On Wed, May 31, 2017 at 03:44:15PM -0700, Jonathan Nieder wrote:
> Subject: send-email: Net::SMTP::starttls was introduced in v3.01
>
> We cannot rely on the starttls method being present in the copy
> of Net::SMTP shipped with perl until v5.21.5~169 (Update libnet to
> CPAN version 3.01, 2014-10-10).
>
> Reported-by: Brandon Williams <bmwill@google.com>
> Reported-by: Eric Biggers <ebiggers3@gmail.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> Hi Eric,
>
> Eric Biggers wrote:
>
> > There seems to be a bug in 'git send-email' caused by this commit:
> >
> > commit 0ead000c3aca13a10ae51a3c74c866981e0d33b8
> > Author: Dennis Kaarsemaker <dennis@kaarsemaker.net>
> > Date: Fri Mar 24 22:37:32 2017 +0100
> >
> > send-email: Net::SMTP::SSL is obsolete, use only when necessary
> >
> > When running git send-email I get the following error:
> >
> > Can't locate object method "starttls" via package "Net::SMTP" at /usr/lib/git-core/git-send-email line 1410.
> >
> > The perl version is 5.18.2, and the Net::SMTP version is 2.31.
>
> Thanks for reporting. Does this patch help?
>
> Regards,
> Jonathan
>
> git-send-email.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 0d90439d9..3441e3cf5 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1354,7 +1354,7 @@ EOF
> }
>
> require Net::SMTP;
> - my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("1.28");
> + my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("3.01");
> $smtp_domain ||= maildomain();
>
> if ($smtp_encryption eq 'ssl') {
> --
Yes, that solves the problem for me.
Eric
next prev parent reply other threads:[~2017-05-31 22:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 22:24 [BUG] git-send-email broken: Can't locate object method "starttls" Eric Biggers
2017-05-31 22:44 ` [PATCH] send-email: Net::SMTP::starttls was introduced in v3.01 (Re: [BUG] git-send-email broken: Can't locate object method "starttls") Jonathan Nieder
2017-05-31 22:51 ` Junio C Hamano
2017-05-31 22:57 ` Eric Biggers [this message]
2017-05-31 23:01 ` Jonathan Nieder
2017-06-01 0:17 ` [PATCH v2] send-email: Net::SMTP::starttls was introduced in v2.34 " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531225708.GE72735@gmail.com \
--to=ebiggers3@gmail.com \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).