* [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX
@ 2017-05-03 13:54 Ævar Arnfjörð Bjarmason
2017-05-03 19:47 ` Jonathan Nieder
0 siblings, 1 reply; 4+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2017-05-03 13:54 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Ævar Arnfjörð Bjarmason
Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.
Since commit 2f8952250a ("regex: add regexec_buf() that can work on a
non NUL-terminated string", 2016-09-21) git has errored out at
compile-time if the regular expression library doesn't support
REG_STARTEND.
While looking through Google search results for the use of NO_REGEX I
found a Chef recipe that set this on AIX[1], looking through the
documentation for the latest version of AIX (7.2, released October
2015) shows that its regexec() doesn't have REG_STARTEND.
1. https://github.com/chef/omnibus-software/commit/e247e36761#diff-3df898345d670979b74acc0bf71d8c47
2. https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.basetrf2/regexec.htm
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
config.mak.uname | 1 +
1 file changed, 1 insertion(+)
diff --git a/config.mak.uname b/config.mak.uname
index 399fe19271..192629f143 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -237,6 +237,7 @@ ifeq ($(uname_S),AIX)
NO_MKDTEMP = YesPlease
NO_STRLCPY = YesPlease
NO_NSEC = YesPlease
+ NO_REGEX = NeedsStartEnd
FREAD_READS_DIRECTORIES = UnfortunatelyYes
INTERNAL_QSORT = UnfortunatelyYes
NEEDS_LIBICONV = YesPlease
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX
2017-05-03 13:54 [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX Ævar Arnfjörð Bjarmason
@ 2017-05-03 19:47 ` Jonathan Nieder
2017-05-03 20:00 ` Stefan Beller
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Nieder @ 2017-05-03 19:47 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason
Cc: git, Junio C Hamano, Johannes Schindelin
Ævar Arnfjörð Bjarmason wrote:
> Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.
>
> Since commit 2f8952250a ("regex: add regexec_buf() that can work on a
> non NUL-terminated string", 2016-09-21) git has errored out at
> compile-time if the regular expression library doesn't support
> REG_STARTEND.
>
> While looking through Google search results for the use of NO_REGEX I
> found a Chef recipe that set this on AIX[1], looking through the
> documentation for the latest version of AIX (7.2, released October
> 2015) shows that its regexec() doesn't have REG_STARTEND.
>
> 1. https://github.com/chef/omnibus-software/commit/e247e36761#diff-3df898345d670979b74acc0bf71d8c47
> 2. https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.basetrf2/regexec.htm
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> config.mak.uname | 1 +
> 1 file changed, 1 insertion(+)
Thanks.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Is there e.g. a build farm where we can check for this kind of thing
more systematically on supported platforms?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX
2017-05-03 19:47 ` Jonathan Nieder
@ 2017-05-03 20:00 ` Stefan Beller
2017-05-03 20:04 ` Jonathan Nieder
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Beller @ 2017-05-03 20:00 UTC (permalink / raw)
To: Jonathan Nieder
Cc: Ævar Arnfjörð Bjarmason, git@vger.kernel.org,
Junio C Hamano, Johannes Schindelin
On Wed, May 3, 2017 at 12:47 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>
> Is there e.g. a build farm where we can check for this kind of thing
> more systematically on supported platforms?
There is the OpenSuse build farm that provides builds for all kinds of
linux distributions, though we'd rather be looking for *all*
operating systems, not just various flavors of linux.
After some research, I found
https://gcc.gnu.org/wiki/CompileFarm
https://launchpad.net/builders
https://buildd.debian.org/
The gcc build farm would include AIX, maybe we could talk to
them to have more CI support on more platforms?
Also you're a DD, maybe we could hook up git testing on debian
to test for different hardware platforms?
Thanks,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX
2017-05-03 20:00 ` Stefan Beller
@ 2017-05-03 20:04 ` Jonathan Nieder
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Nieder @ 2017-05-03 20:04 UTC (permalink / raw)
To: Stefan Beller
Cc: Ævar Arnfjörð Bjarmason, git@vger.kernel.org,
Junio C Hamano, Johannes Schindelin
Hi,
Stefan Beller wrote:
> On Wed, May 3, 2017 at 12:47 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Is there e.g. a build farm where we can check for this kind of thing
>> more systematically on supported platforms?
>
> There is the OpenSuse build farm that provides builds for all kinds of
> linux distributions, though we'd rather be looking for *all*
> operating systems, not just various flavors of linux.
>
> After some research, I found
> https://gcc.gnu.org/wiki/CompileFarm
> https://launchpad.net/builders
> https://buildd.debian.org/
>
> The gcc build farm would include AIX, maybe we could talk to
> them to have more CI support on more platforms?
Thanks for the pointers.
> Also you're a DD, maybe we could hook up git testing on debian
> to test for different hardware platforms?
https://buildd.debian.org/status/package.php?p=git&suite=experimental
shows test suite results for Debian's various platforms running "next".
Hope that helps,
Jonathan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-03 20:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-03 13:54 [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX Ævar Arnfjörð Bjarmason
2017-05-03 19:47 ` Jonathan Nieder
2017-05-03 20:00 ` Stefan Beller
2017-05-03 20:04 ` Jonathan Nieder
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).