Re: [PATCH v2 2/2] push: propagate push-options with --recurse-submodules

[Jonathan Nieder <jrnieder@gmail.com>]

Brandon Williams wrote:

> Teach push --recurse-submodules to propagate push-options recursively to
> the pushes performed in the submodules.

Some time in the future we may want "push --recurse-submodules" to do a
dry run pass before doing the final push, so that if it is known that
some of the pushes wouldn't succeed (e.g. due to not being
fast-forward, or the server not being reachable, or the server not
supporting push options) then git could stop early instead of some
succeeding and some failing.

But that's a larger and separate change from this one.  Users of push
--recurse-submodules today know they are effectively asking for
multiple pushes that are not guaranteed to succeed or fail together.

> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  submodule.c             | 13 +++++++++++--
>  submodule.h             |  1 +
>  t/t5545-push-options.sh | 39 +++++++++++++++++++++++++++++++++++++++
>  transport.c             |  1 +
>  4 files changed, 52 insertions(+), 2 deletions(-)

For what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>