From: Brandon Williams <bmwill@google.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] push: propagate push-options with --recurse-submodules
Date: Fri, 31 Mar 2017 16:26:31 -0700 [thread overview]
Message-ID: <20170331232631.GA40772@google.com> (raw)
In-Reply-To: <20170331232030.GA8741@aiede.mtv.corp.google.com>
On 03/31, Jonathan Nieder wrote:
> Hi,
>
> Brandon Williams wrote:
>
> > Teach push --recurse-submodules to propagate push-options recursively to
> > the pushes performed in the submodules.
>
> Sounds like a good change.
>
> [...]
> > +++ b/submodule.c
> [...]
> > @@ -793,6 +794,12 @@ static int push_submodule(const char *path, int dry_run)
> > if (dry_run)
> > argv_array_push(&cp.args, "--dry-run");
> >
> > + if (push_options && push_options->nr) {
> > + static struct string_list_item *item;
>
> Why static? It would be simpler (and would use less bss) to let this
> pointer be an automatic variable instead.
Oops, definitely shouldn't be static! Thanks for catching that.
>
> > + for_each_string_list_item(item, push_options)
> > + argv_array_pushf(&cp.args, "--push-option=%s",
> > + item->string);
> > + }
> > prepare_submodule_repo_env(&cp.env_array);
> > cp.git_cmd = 1;
> > cp.no_stdin = 1;
> > @@ -807,7 +814,8 @@ static int push_submodule(const char *path, int dry_run)
> >
> > int push_unpushed_submodules(struct sha1_array *commits,
> > const char *remotes_name,
> > - int dry_run)
> > + int dry_run,
> > + const struct string_list *push_options)
>
> nit: I wonder if dry_run should stay as the last argument. That would
> make it closer to the idiom of have a flag word as last argument.
Yeah I can flip the order.
>
> [...]
> > +++ b/t/t5545-push-options.sh
> > @@ -142,6 +142,45 @@ test_expect_success 'push options work properly across http' '
> > test_cmp expect actual
> > '
> >
> > +test_expect_success 'push options and submodules' '
>
> Yay!
>
> What happens if the upstream of the parent repo supports push options
> but the upstream of the child repo doesn't? What should happen?
push would fail since the children are pushed first.
>
> Thanks and hope that helps,
> Jonathan
--
Brandon Williams
next prev parent reply other threads:[~2017-03-31 23:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 23:11 [PATCH] push: propagate push-options with --recurse-submodules Brandon Williams
2017-03-31 23:20 ` Jonathan Nieder
2017-03-31 23:26 ` Brandon Williams [this message]
2017-03-31 23:56 ` [PATCH v2 0/2] propagate push-options Brandon Williams
2017-03-31 23:56 ` [PATCH v2 1/2] push: unmark a local variable as static Brandon Williams
2017-04-01 0:11 ` Jonathan Nieder
2017-04-01 0:16 ` Brandon Williams
2017-03-31 23:56 ` [PATCH v2 2/2] push: propagate push-options with --recurse-submodules Brandon Williams
2017-04-01 0:19 ` Jonathan Nieder
2017-04-06 0:17 ` Jacob Keller
2017-04-06 17:39 ` Brandon Williams
2017-04-05 17:47 ` [PATCH v3 0/5] propagating push-options, remote and refspec Brandon Williams
2017-04-05 17:47 ` [PATCH v3 1/5] push: unmark a local variable as static Brandon Williams
2017-04-05 17:47 ` [PATCH v3 2/5] push: propagate push-options with --recurse-submodules Brandon Williams
2017-04-05 17:47 ` [PATCH v3 3/5] remote: expose parse_push_refspec function Brandon Williams
2017-04-05 17:47 ` [PATCH v3 4/5] submodule--helper: add push-check subcommand Brandon Williams
2017-04-05 17:47 ` [PATCH v3 5/5] push: propagate remote and refspec with --recurse-submodules Brandon Williams
2017-04-11 7:44 ` [PATCH v3 0/5] propagating push-options, remote and refspec Junio C Hamano
2017-04-11 16:33 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331232631.GA40772@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).