From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] receive-pack: simplify run_update_post_hook()
Date: Sun, 19 Mar 2017 23:35:31 -0400 [thread overview]
Message-ID: <20170320033530.sl4rbd2lq3qo2kgl@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqshma4ihk.fsf@gitster.mtv.corp.google.com>
On Sat, Mar 18, 2017 at 10:12:07AM -0700, Junio C Hamano wrote:
> >> - argv_array_push(&proc.args, hook);
> >> for (cmd = commands; cmd; cmd = cmd->next) {
> >> if (cmd->error_string || cmd->did_not_exist)
> >> continue;
> >> + if (!proc.args.argc)
> >> + argv_array_push(&proc.args, hook);
> >> argv_array_push(&proc.args, cmd->ref_name);
> >> }
> >> + if (!proc.args.argc)
> >> + return;
> >
> > It looks at first like the result leaks, because you have to realize
> > that the push will modify proc.args.argc.
>
> Hmph, I needed to read the original twice to imagine how a paranoid
> person can fear leaks. The return condition says "if args array is
> empty, just return" and the thing being empty is an enough indication
> to think nothing is leaking, at least for me.
Yeah, I think I just read it funny the first time. I'm OK with it as-is.
-Peff
next prev parent reply other threads:[~2017-03-20 3:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 22:02 [PATCH] receive-pack: simplify run_update_post_hook() René Scharfe
2017-03-17 22:23 ` Jeff King
2017-03-17 23:21 ` René Scharfe
2017-03-18 17:12 ` Junio C Hamano
2017-03-20 3:35 ` Jeff King [this message]
2017-03-17 22:50 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320033530.sl4rbd2lq3qo2kgl@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).