From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] receive-pack: simplify run_update_post_hook()
Date: Fri, 17 Mar 2017 18:23:20 -0400 [thread overview]
Message-ID: <20170317222320.nsg3yk3nopjadr5t@sigill.intra.peff.net> (raw)
In-Reply-To: <ac1c0cfc-b1de-37be-23b3-98ef1081ec4a@web.de>
On Fri, Mar 17, 2017 at 11:02:13PM +0100, René Scharfe wrote:
> Instead of counting the arguments to see if there are any and then
> building the full command use a single loop and add the hook command
> just before the first argument. This reduces duplication and overall
> code size.
Yeah, I agree one loop is nicer.
> - argv_array_push(&proc.args, hook);
> for (cmd = commands; cmd; cmd = cmd->next) {
> if (cmd->error_string || cmd->did_not_exist)
> continue;
> + if (!proc.args.argc)
> + argv_array_push(&proc.args, hook);
> argv_array_push(&proc.args, cmd->ref_name);
> }
> + if (!proc.args.argc)
> + return;
It looks at first like the result leaks, because you have to realize
that the push will modify proc.args.argc. I wonder if:
argv_array_push(&proc.args, hook);
for (cmd = commands; cmd; cmd = cmd->next) {
if (!cmd->error_string && !cmd->did_not_exist)
argv_array_push(&proc.args, cmd->ref_name);
}
if (proc.args.argc == 1) {
argv_array_clear(&proc.args);
return;
}
would be more obvious (at the cost of a pointless malloc in the corner
case. I can live with it either way.
-Peff
next prev parent reply other threads:[~2017-03-17 23:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 22:02 [PATCH] receive-pack: simplify run_update_post_hook() René Scharfe
2017-03-17 22:23 ` Jeff King [this message]
2017-03-17 23:21 ` René Scharfe
2017-03-18 17:12 ` Junio C Hamano
2017-03-20 3:35 ` Jeff King
2017-03-17 22:50 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317222320.nsg3yk3nopjadr5t@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).