From: Jeff King <peff@peff.net>
To: Brandon Williams <bmwill@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Rahul Bedarkar <rahul.bedarkar@imgtec.com>,
git@vger.kernel.org
Subject: Re: [PATCH] grep: fix build with no thread support
Date: Fri, 17 Mar 2017 18:58:48 -0400 [thread overview]
Message-ID: <20170317225847.g5776lntj7d5ni3v@sigill.intra.peff.net> (raw)
In-Reply-To: <20170317224232.GE63813@google.com>
On Fri, Mar 17, 2017 at 03:42:32PM -0700, Brandon Williams wrote:
> > > I didn't take a close look at it but this would seem to indicate that we
> > > don't worry to much about systems without pthreads support. Just food
> > > for thought.
> >
> > Hmm. We used to. What version did you test? Everything passes for me at
> > 0281e487f^ (after that it fails to build). So AFAICT v2.12.0 is the
> > first release which does not work with NO_PTHREADS.
> >
> > -Peff
>
> The version I ran tests on was what the master branch was pointing to a
> day or so ago:
>
> v2.12.0-264-gd6db3f216
Ah, OK. I couldn't get such a recent version to build with NO_PTHREADS,
but I assume you mean after applying your two patches.
v2.11.0 is fine, but v2.12.0 with your patches shows the problem.
Bisecting (and applying the patches when necessary) points to my
46df6906f (execv_dashed_external: wait for child on signal death,
2017-01-06).
-Peff
next prev parent reply other threads:[~2017-03-17 23:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 5:47 [PATCH] grep: fix build with no thread support Rahul Bedarkar
2017-03-17 17:53 ` Junio C Hamano
2017-03-17 18:24 ` Brandon Williams
2017-03-17 18:41 ` [PATCH 1/2] grep: set default output method Brandon Williams
2017-03-17 18:41 ` [PATCH 2/2] grep: fix builds with with no thread support Brandon Williams
2017-03-17 23:00 ` Jonathan Nieder
2017-03-20 5:55 ` Rahul Bedarkar
2017-03-17 18:47 ` [PATCH] grep: fix build " Brandon Williams
2017-03-17 22:37 ` Jeff King
2017-03-17 22:42 ` Brandon Williams
2017-03-17 22:58 ` Jeff King [this message]
2017-03-17 23:03 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317225847.g5776lntj7d5ni3v@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rahul.bedarkar@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).