From: Brandon Williams <bmwill@google.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Rahul Bedarkar <rahul.bedarkar@imgtec.com>,
git@vger.kernel.org
Subject: Re: [PATCH] grep: fix build with no thread support
Date: Fri, 17 Mar 2017 15:42:32 -0700 [thread overview]
Message-ID: <20170317224232.GE63813@google.com> (raw)
In-Reply-To: <20170317223741.qwfh2zw37y3jbeev@sigill.intra.peff.net>
On 03/17, Jeff King wrote:
> On Fri, Mar 17, 2017 at 11:47:01AM -0700, Brandon Williams wrote:
>
> > While taking a look at this bug I discovered that the test suite doesn't
> > pass 100% of the test when compiled with the NO_PTHREADS option. The
> > following tests seem to be failing:
> >
> > t1060-object-corruption.sh (Wstat: 256 Tests: 13 Failed: 3)
> > Failed tests: 7-9
> > Non-zero exit status: 1
> > t5306-pack-nobase.sh (Wstat: 256 Tests: 4 Failed: 1)
> > Failed test: 4
> > Non-zero exit status: 1
> > t5504-fetch-receive-strict.sh (Wstat: 256 Tests: 12 Failed: 2)
> > Failed tests: 4-5
> > Non-zero exit status: 1
> > t5530-upload-pack-error.sh (Wstat: 256 Tests: 10 Failed: 1)
> > Failed test: 10
> > Non-zero exit status: 1
> >
> > I didn't take a close look at it but this would seem to indicate that we
> > don't worry to much about systems without pthreads support. Just food
> > for thought.
>
> Hmm. We used to. What version did you test? Everything passes for me at
> 0281e487f^ (after that it fails to build). So AFAICT v2.12.0 is the
> first release which does not work with NO_PTHREADS.
>
> -Peff
The version I ran tests on was what the master branch was pointing to a
day or so ago:
v2.12.0-264-gd6db3f216
--
Brandon Williams
next prev parent reply other threads:[~2017-03-17 22:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 5:47 [PATCH] grep: fix build with no thread support Rahul Bedarkar
2017-03-17 17:53 ` Junio C Hamano
2017-03-17 18:24 ` Brandon Williams
2017-03-17 18:41 ` [PATCH 1/2] grep: set default output method Brandon Williams
2017-03-17 18:41 ` [PATCH 2/2] grep: fix builds with with no thread support Brandon Williams
2017-03-17 23:00 ` Jonathan Nieder
2017-03-20 5:55 ` Rahul Bedarkar
2017-03-17 18:47 ` [PATCH] grep: fix build " Brandon Williams
2017-03-17 22:37 ` Jeff King
2017-03-17 22:42 ` Brandon Williams [this message]
2017-03-17 22:58 ` Jeff King
2017-03-17 23:03 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317224232.GE63813@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=rahul.bedarkar@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).