From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] tests: create an interactive gdb session with the 'debug' helper
Date: Fri, 17 Mar 2017 10:55:05 -0400 [thread overview]
Message-ID: <20170317145504.utysxd4qqaqetm7t@sigill.intra.peff.net> (raw)
In-Reply-To: <20170317144646.9349-1-szeder.dev@gmail.com>
On Fri, Mar 17, 2017 at 03:46:46PM +0100, SZEDER Gábor wrote:
> The 'debug' test helper is supposed to facilitate debugging by running
> a command of the test suite under gdb. Unfortunately, its usefulness
> is severely limited, because that gdb session is not interactive,
> since the test's, and thus gdb's standard input is attached to
> /dev/null (for a good reason, see 781f76b15 (test-lib: redirect stdin
> of tests, 2011-12-15)).
>
> Re-attach the original standard input in the debug helper, thus
> creating an interactive gdb session, which is much much more useful.
Yeah, I think I've had to do a similar hack manually. This is an obvious
improvement. Though...
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index bd357704c..9567dc986 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -154,7 +154,7 @@ test_pause () {
> #
> # Example: "debug git checkout master".
> debug () {
> - GIT_TEST_GDB=1 "$@"
> + GIT_TEST_GDB=1 "$@" <&6
> }
Your stderr and stdout may be redirected, too. That's usually not a big
problem because you'll be using "-v", but perhaps this should add:
>&3 2>&4
to be on the safe side. That covers running without "-v", as well as
cases where the test script is redirecting output (I _actually_ wish gdb
behaved like perl's debugger and unconditionally used the terminal,
retaining existing redirections, but I AFAIK there's no easy way to get
it to do that).
-Peff
next prev parent reply other threads:[~2017-03-17 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 14:46 [PATCH] tests: create an interactive gdb session with the 'debug' helper SZEDER Gábor
2017-03-17 14:55 ` Jeff King [this message]
2017-03-18 16:10 ` SZEDER Gábor
2017-03-18 16:13 ` [PATCHv2 1/2] " SZEDER Gábor
2017-03-18 16:14 ` [PATCHv2 2/2] tests: make the 'test_pause' helper work in non-verbose mode SZEDER Gábor
2017-03-20 4:32 ` Jeff King
2017-03-20 4:31 ` [PATCHv2 1/2] tests: create an interactive gdb session with the 'debug' helper Jeff King
2017-03-21 11:07 ` Johannes Schindelin
2017-03-20 4:29 ` [PATCH] " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317145504.utysxd4qqaqetm7t@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).