From: Jeff King <peff@peff.net> To: SZEDER Gábor <szeder.dev@gmail.com> Cc: Junio C Hamano <gitster@pobox.com>, Johannes Schindelin <johannes.schindelin@gmx.de>, git@vger.kernel.org Subject: Re: [PATCHv2 1/2] tests: create an interactive gdb session with the 'debug' helper Date: Mon, 20 Mar 2017 00:31:34 -0400 Message-ID: <20170320043134.exaiz6adzcxp4zld@sigill.intra.peff.net> (raw) In-Reply-To: <20170318161400.19753-1-szeder.dev@gmail.com> On Sat, Mar 18, 2017 at 05:13:59PM +0100, SZEDER Gábor wrote: > The 'debug' test helper is supposed to facilitate debugging by running > a command of the test suite under gdb. Unfortunately, its usefulness > is severely limited, because that gdb session is not interactive, > since the test's, and thus gdb's standard input is redirected from > /dev/null (for a good reason, see 781f76b15 (test-lib: redirect stdin > of tests, 2011-12-15)). > > Redirect gdb's standard file descriptors from/to the test > environment's stdin, stdout and stderr in the 'debug' helper, thus > creating an interactive gdb session (even in non-verbose mode), which > is much, much more useful. > > [...] > > debug () { > - GIT_TEST_GDB=1 "$@" > + GIT_TEST_GDB=1 "$@" <&6 >&5 2>&7 > } Yep, this looks fine to me. > diff --git a/t/test-lib.sh b/t/test-lib.sh > index 86d77c16d..23c29bce6 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -342,6 +342,7 @@ fi > > exec 5>&1 > exec 6<&0 > +exec 7>&2 And this obviously is required to keep stdout/stderr separate. -Peff
next prev parent reply index Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-17 14:46 [PATCH] " SZEDER Gábor 2017-03-17 14:55 ` Jeff King 2017-03-18 16:10 ` SZEDER Gábor 2017-03-18 16:13 ` [PATCHv2 1/2] " SZEDER Gábor 2017-03-18 16:14 ` [PATCHv2 2/2] tests: make the 'test_pause' helper work in non-verbose mode SZEDER Gábor 2017-03-20 4:32 ` Jeff King 2017-03-20 4:31 ` Jeff King [this message] 2017-03-21 11:07 ` [PATCHv2 1/2] tests: create an interactive gdb session with the 'debug' helper Johannes Schindelin 2017-03-20 4:29 ` [PATCH] " Jeff King
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170320043134.exaiz6adzcxp4zld@sigill.intra.peff.net \ --to=peff@peff.net \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=johannes.schindelin@gmx.de \ --cc=szeder.dev@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org mailing list mirror (one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ or Tor2web: https://www.tor2web.org/ AGPL code for this site: git clone https://public-inbox.org/ public-inbox