From: Jeff King <peff@peff.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Allow "git shortlog" to group by committer information
Date: Fri, 16 Dec 2016 08:51:41 -0500 [thread overview]
Message-ID: <20161216135141.yhas67pzfm7bxxum@sigill.intra.peff.net> (raw)
In-Reply-To: <20161216133940.hu474phggdslh6ka@sigill.intra.peff.net>
On Fri, Dec 16, 2016 at 08:39:40AM -0500, Jeff King wrote:
> I'm OK with the approach your patch takes, but I think there were some
> unresolved issues:
>
> - are we OK taking the short "-c" for this, or do we want
> "--group-by=committer" or something like it?
>
> - no tests; you can steal the general form from my [1]
>
> - no documentation (can also be stolen from [1], though the syntax is
> quite different)
Being moved by the holiday spirit, I wrote a patch to address the latter
two. ;)
It obviously would need updating if we switch away from "-c", but I
think I am OK with the short "-c" (even if we add a more exotic grouping
option later, this can remain as a short synonym).
-- >8 --
Subject: [PATCH] shortlog: test and document --committer option
This puts the final touches on the feature added by
fbfda15fb8 (shortlog: group by committer information,
2016-10-11).
Signed-off-by: Jeff King <peff@peff.net>
---
Documentation/git-shortlog.txt | 4 ++++
t/t4201-shortlog.sh | 13 +++++++++++++
2 files changed, 17 insertions(+)
diff --git a/Documentation/git-shortlog.txt b/Documentation/git-shortlog.txt
index 31af7f2736..ee6c5476c1 100644
--- a/Documentation/git-shortlog.txt
+++ b/Documentation/git-shortlog.txt
@@ -47,6 +47,10 @@ OPTIONS
Each pretty-printed commit will be rewrapped before it is shown.
+-c::
+--committer::
+ Collect and show committer identities instead of authors.
+
-w[<width>[,<indent1>[,<indent2>]]]::
Linewrap the output by wrapping each line at `width`. The first
line of each entry is indented by `indent1` spaces, and the second
diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh
index ae08b57712..6c7c637481 100755
--- a/t/t4201-shortlog.sh
+++ b/t/t4201-shortlog.sh
@@ -190,4 +190,17 @@ test_expect_success 'shortlog with --output=<file>' '
test_line_count = 3 shortlog
'
+test_expect_success 'shortlog --committer (internal)' '
+ cat >expect <<-\EOF &&
+ 3 C O Mitter
+ EOF
+ git shortlog -nsc HEAD >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'shortlog --committer (external)' '
+ git log --format=full | git shortlog -nsc >actual &&
+ test_cmp expect actual
+'
+
test_done
--
2.11.0.348.g960a0b554
next prev parent reply other threads:[~2016-12-16 13:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 18:45 Allow "git shortlog" to group by committer information Linus Torvalds
2016-10-11 19:01 ` Jeff King
2016-10-11 19:07 ` Linus Torvalds
2016-10-11 19:17 ` Jeff King
2016-12-15 21:29 ` Linus Torvalds
2016-12-16 0:19 ` Junio C Hamano
2016-12-16 1:39 ` Linus Torvalds
2016-12-16 4:56 ` Junio C Hamano
2016-12-16 1:45 ` [PATCH 1/1] " Linus Torvalds
2016-12-16 1:51 ` Stephen & Linda Smith
2016-12-16 2:00 ` Linus Torvalds
2016-12-16 13:39 ` Jeff King
2016-12-16 13:51 ` Jeff King [this message]
2016-12-16 17:27 ` Junio C Hamano
2016-12-20 18:12 ` Johannes Sixt
2016-12-20 18:19 ` Junio C Hamano
2016-12-20 18:24 ` Junio C Hamano
2016-12-20 18:35 ` Junio C Hamano
2016-12-20 18:52 ` Johannes Sixt
2016-12-21 21:09 ` Johannes Sixt
2016-12-21 3:22 ` Jeff King
2016-12-21 7:55 ` Jacob Keller
2016-12-21 16:04 ` Jeff King
2016-12-21 20:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216135141.yhas67pzfm7bxxum@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).