From: Jeff King <peff@peff.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Allow "git shortlog" to group by committer information
Date: Tue, 11 Oct 2016 15:17:13 -0400 [thread overview]
Message-ID: <20161011191712.ms3n5uzufko7c7z2@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+55aFzw24pHGOYFBFVvTbU1Cudcr8zcPt_RvdQSxrKY5weCbQ@mail.gmail.com>
On Tue, Oct 11, 2016 at 12:07:40PM -0700, Linus Torvalds wrote:
> On Tue, Oct 11, 2016 at 12:01 PM, Jeff King <peff@peff.net> wrote:
> >
> > My implementation is a little more complicated because it's also setting
> > things up for grouping by trailers (so you can group by "signed-off-by",
> > for example). I don't know if that's useful to your or not.
>
> Hmm. Maybe in theory. But probably not in reality - it's just not
> unique enough (ie there are generally multiple, and if you choose the
> first/last, it should be the same as author/committer, so it doesn't
> actually add anything).
The implementation I did credited each commit multiple times if the
trailer appeared more than once. If you want to play with it, you can
fetch it from:
git://github.com/peff jk/shortlog-ident
and then something like:
git shortlog --ident=reviewed-by --format='...reviewed %an'
works. I haven't found it to really be useful for more than toy
statistic gathering, though.
> There are possibly other things that *could* be grouped by and might be useful:
>
> - main subdirectory it touches (I've often wanted that)
>
> - rough size of diff or number of files it touches
>
> but realistically both are painful enough that it probably doesn't
> make sense to do in some low-level helper.
Yeah, I think there's a lot of policy there in what counts as "main",
the rough sizes, etc. I've definitely done queries like that before, but
usually by piping "log --numstat" into perl. It's a minor pain to get
the data into perl data structures, but once you have it, you have a lot
more flexibility in what you can compute.
That might be aided by providing more structured machine-readable output
from git, like JSON (which I don't particularly like, but it's kind-of a
standard, and it sure as hell beats XML). But obviously that's another
topic entirely.
> > I'm fine with this less invasive version, but a few suggestions:
> >
> > - do you want to call it --group-by=committer (with --group-by=author
> > as the default), which could later extend naturally to other forms of
> > grouping?
>
> Honestly, it's probably the more generic one, but especially for
> one-off commands that aren't that common, it's a pain to write. When
> testing it, I literally just used "-c" for that reason.
It's not the end of the world to call it "-c" now, and later define "-c"
as a shorthand for "--group-by=committer", if and when the latter comes
into existence.
Keep in mind that shortlog takes arbitrary revision options, too, and
"-c" is defined there for combined diffs. I can't think of a good reason
to want to pass it to shortlog, though, so I don't think it's a big
loss.
-Peff
next prev parent reply other threads:[~2016-10-11 19:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 18:45 Allow "git shortlog" to group by committer information Linus Torvalds
2016-10-11 19:01 ` Jeff King
2016-10-11 19:07 ` Linus Torvalds
2016-10-11 19:17 ` Jeff King [this message]
2016-12-15 21:29 ` Linus Torvalds
2016-12-16 0:19 ` Junio C Hamano
2016-12-16 1:39 ` Linus Torvalds
2016-12-16 4:56 ` Junio C Hamano
2016-12-16 1:45 ` [PATCH 1/1] " Linus Torvalds
2016-12-16 1:51 ` Stephen & Linda Smith
2016-12-16 2:00 ` Linus Torvalds
2016-12-16 13:39 ` Jeff King
2016-12-16 13:51 ` Jeff King
2016-12-16 17:27 ` Junio C Hamano
2016-12-20 18:12 ` Johannes Sixt
2016-12-20 18:19 ` Junio C Hamano
2016-12-20 18:24 ` Junio C Hamano
2016-12-20 18:35 ` Junio C Hamano
2016-12-20 18:52 ` Johannes Sixt
2016-12-21 21:09 ` Johannes Sixt
2016-12-21 3:22 ` Jeff King
2016-12-21 7:55 ` Jacob Keller
2016-12-21 16:04 ` Jeff King
2016-12-21 20:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011191712.ms3n5uzufko7c7z2@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).