* [PATCH v3 0/5] Add --format to tag verification
@ 2016-09-30 22:18 santiago
2016-09-30 22:18 ` [PATCH v3 1/5] gpg-interface, tag: add GPG_VERIFY_QUIET flag santiago
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: santiago @ 2016-09-30 22:18 UTC (permalink / raw)
To: git; +Cc: gitster, peff, sunshine, walters, Santiago Torres
From: Santiago Torres <santiago@nyu.edu>
This is the third iteration of [1][2], and as a result of the discussion
in [3].
In this re-roll we:
* Fixed all the signed-off-by's
[0002]
* Renamed the function format_ref to pretty_print_ref instead, which
is a more descriptive name
[0004]
* Added the respective line for the new --format parameter in the
documentation.
[0005]
* Added mention of the --format flag in the documentation files.
* Fixed the function signatures, now they take an opaque void *cb_data pointer
so it can be used in a more general way (by e.g., delete_tag).
This patch applies to 2.10.0 and master.
[1] http://public-inbox.org/git/20160922185317.349-1-santiago@nyu.edu/
[2] http://public-inbox.org/git/20160926224233.32702-1-santiago@nyu.edu/
[3] http://public-inbox.org/git/20160607195608.16643-1-santiago@nyu.edu/
Lukas Puehringer (4):
gpg-interface, tag: add GPG_VERIFY_QUIET flag
ref-filter: add function to print single ref_array_item
tag: add format specifier to gpg_verify_tag
builtin/tag: add --format argument for tag -v
Santiago Torres (1):
builtin/verify-tag: add --format to verify-tag
Documentation/git-tag.txt | 2 +-
Documentation/git-verify-tag.txt | 2 +-
builtin/tag.c | 34 +++++++++++++++++++++++-----------
builtin/verify-tag.c | 13 +++++++++++--
gpg-interface.h | 1 +
ref-filter.c | 10 ++++++++++
ref-filter.h | 3 +++
tag.c | 22 +++++++++++++++-------
tag.h | 4 ++--
9 files changed, 67 insertions(+), 24 deletions(-)
--
2.10.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3 1/5] gpg-interface, tag: add GPG_VERIFY_QUIET flag
2016-09-30 22:18 [PATCH v3 0/5] Add --format to tag verification santiago
@ 2016-09-30 22:18 ` santiago
2016-09-30 22:18 ` [PATCH v3 2/5] ref-filter: add function to print single ref_array_item santiago
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: santiago @ 2016-09-30 22:18 UTC (permalink / raw)
To: git; +Cc: gitster, peff, sunshine, walters, Lukas Puehringer
From: Lukas Puehringer <luk.puehringer@gmail.com>
Functions that print git object information may require that the
gpg-interface functions be silent. Add GPG_VERIFY_QUIET flag and prevent
print_signature_buffer from being called if flag is set.
Signed-off-by: Lukas Puehringer <luk.puehringer@gmail.com>
---
gpg-interface.h | 1 +
tag.c | 5 ++++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gpg-interface.h b/gpg-interface.h
index ea68885..85dc982 100644
--- a/gpg-interface.h
+++ b/gpg-interface.h
@@ -3,6 +3,7 @@
#define GPG_VERIFY_VERBOSE 1
#define GPG_VERIFY_RAW 2
+#define GPG_VERIFY_QUIET 4
struct signature_check {
char *payload;
diff --git a/tag.c b/tag.c
index d1dcd18..291073f 100644
--- a/tag.c
+++ b/tag.c
@@ -3,6 +3,7 @@
#include "commit.h"
#include "tree.h"
#include "blob.h"
+#include "gpg-interface.h"
const char *tag_type = "tag";
@@ -24,7 +25,9 @@ static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
ret = check_signature(buf, payload_size, buf + payload_size,
size - payload_size, &sigc);
- print_signature_buffer(&sigc, flags);
+
+ if (!(flags & GPG_VERIFY_QUIET))
+ print_signature_buffer(&sigc, flags);
signature_check_clear(&sigc);
return ret;
--
2.10.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 2/5] ref-filter: add function to print single ref_array_item
2016-09-30 22:18 [PATCH v3 0/5] Add --format to tag verification santiago
2016-09-30 22:18 ` [PATCH v3 1/5] gpg-interface, tag: add GPG_VERIFY_QUIET flag santiago
@ 2016-09-30 22:18 ` santiago
2016-09-30 23:12 ` Jakub Narębski
2016-09-30 22:18 ` [PATCH v3 3/5] tag: add format specifier to gpg_verify_tag santiago
` (3 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: santiago @ 2016-09-30 22:18 UTC (permalink / raw)
To: git; +Cc: gitster, peff, sunshine, walters, Lukas Puehringer
From: Lukas Puehringer <luk.puehringer@gmail.com>
ref-filter functions are useful for printing git object information
using a format specifier. However, some other modules may not want to use
this functionality on a ref-array but only print a single item.
Expose a format_ref function to create, pretty print and free individual
ref-items.
Signed-off-by: Lukas Puehringer <luk.puehringer@gmail.com>
---
ref-filter.c | 10 ++++++++++
ref-filter.h | 3 +++
2 files changed, 13 insertions(+)
diff --git a/ref-filter.c b/ref-filter.c
index bc551a7..ee3ed67 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1655,6 +1655,16 @@ void show_ref_array_item(struct ref_array_item *info, const char *format, int qu
putchar('\n');
}
+void pretty_print_ref(const char *name, const unsigned char *sha1,
+ const char *format, unsigned kind)
+{
+ struct ref_array_item *ref_item;
+ ref_item = new_ref_array_item(name, sha1, 0);
+ ref_item->kind = kind;
+ show_ref_array_item(ref_item, format, 0);
+ free_array_item(ref_item);
+}
+
/* If no sorting option is given, use refname to sort as default */
struct ref_sorting *ref_default_sorting(void)
{
diff --git a/ref-filter.h b/ref-filter.h
index 14d435e..3d23090 100644
--- a/ref-filter.h
+++ b/ref-filter.h
@@ -107,4 +107,7 @@ struct ref_sorting *ref_default_sorting(void);
/* Function to parse --merged and --no-merged options */
int parse_opt_merge_filter(const struct option *opt, const char *arg, int unset);
+void pretty_print_ref(const char *name, const unsigned char *sha1,
+ const char *format, unsigned kind);
+
#endif /* REF_FILTER_H */
--
2.10.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 3/5] tag: add format specifier to gpg_verify_tag
2016-09-30 22:18 [PATCH v3 0/5] Add --format to tag verification santiago
2016-09-30 22:18 ` [PATCH v3 1/5] gpg-interface, tag: add GPG_VERIFY_QUIET flag santiago
2016-09-30 22:18 ` [PATCH v3 2/5] ref-filter: add function to print single ref_array_item santiago
@ 2016-09-30 22:18 ` santiago
2016-09-30 22:18 ` [PATCH v3 4/5] builtin/verify-tag: add --format to verify-tag santiago
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: santiago @ 2016-09-30 22:18 UTC (permalink / raw)
To: git; +Cc: gitster, peff, sunshine, walters, Lukas P
From: Lukas P <luk.puehringer@gmail.com>
Calling functions for gpg_verify_tag() may desire to print relevant
information about the header for further verification. Add an optional
format argument to print any desired information after GPG verification.
Signed-off-by: Lukas Puehringer <luk.puehringer@gmail.com>
---
builtin/tag.c | 2 +-
builtin/verify-tag.c | 2 +-
tag.c | 17 +++++++++++------
tag.h | 4 ++--
4 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/builtin/tag.c b/builtin/tag.c
index 50e4ae5..14f3b48 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -105,7 +105,7 @@ static int delete_tag(const char *name, const char *ref,
static int verify_tag(const char *name, const char *ref,
const unsigned char *sha1)
{
- return gpg_verify_tag(sha1, name, GPG_VERIFY_VERBOSE);
+ return verify_and_format_tag(sha1, name, NULL, GPG_VERIFY_VERBOSE);
}
static int do_sign(struct strbuf *buffer)
diff --git a/builtin/verify-tag.c b/builtin/verify-tag.c
index 99f8148..de10198 100644
--- a/builtin/verify-tag.c
+++ b/builtin/verify-tag.c
@@ -51,7 +51,7 @@ int cmd_verify_tag(int argc, const char **argv, const char *prefix)
const char *name = argv[i++];
if (get_sha1(name, sha1))
had_error = !!error("tag '%s' not found.", name);
- else if (gpg_verify_tag(sha1, name, flags))
+ else if (verify_and_format_tag(sha1, name, NULL, flags))
had_error = 1;
}
return had_error;
diff --git a/tag.c b/tag.c
index 291073f..d3512c0 100644
--- a/tag.c
+++ b/tag.c
@@ -4,6 +4,7 @@
#include "tree.h"
#include "blob.h"
#include "gpg-interface.h"
+#include "ref-filter.h"
const char *tag_type = "tag";
@@ -33,8 +34,8 @@ static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
return ret;
}
-int gpg_verify_tag(const unsigned char *sha1, const char *name_to_report,
- unsigned flags)
+int verify_and_format_tag(const unsigned char *sha1, const char *name,
+ const char *fmt_pretty, unsigned flags)
{
enum object_type type;
char *buf;
@@ -44,21 +45,25 @@ int gpg_verify_tag(const unsigned char *sha1, const char *name_to_report,
type = sha1_object_info(sha1, NULL);
if (type != OBJ_TAG)
return error("%s: cannot verify a non-tag object of type %s.",
- name_to_report ?
- name_to_report :
+ name ?
+ name :
find_unique_abbrev(sha1, DEFAULT_ABBREV),
typename(type));
buf = read_sha1_file(sha1, &type, &size);
if (!buf)
return error("%s: unable to read file.",
- name_to_report ?
- name_to_report :
+ name ?
+ name :
find_unique_abbrev(sha1, DEFAULT_ABBREV));
ret = run_gpg_verify(buf, size, flags);
free(buf);
+
+ if (fmt_pretty)
+ pretty_print_ref(name, sha1, fmt_pretty, FILTER_REFS_TAGS);
+
return ret;
}
diff --git a/tag.h b/tag.h
index a5721b6..896b9c2 100644
--- a/tag.h
+++ b/tag.h
@@ -17,7 +17,7 @@ extern int parse_tag_buffer(struct tag *item, const void *data, unsigned long si
extern int parse_tag(struct tag *item);
extern struct object *deref_tag(struct object *, const char *, int);
extern struct object *deref_tag_noverify(struct object *);
-extern int gpg_verify_tag(const unsigned char *sha1,
- const char *name_to_report, unsigned flags);
+extern int verify_and_format_tag(const unsigned char *sha1, const char *name,
+ const char *fmt_pretty, unsigned flags);
#endif /* TAG_H */
--
2.10.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 4/5] builtin/verify-tag: add --format to verify-tag
2016-09-30 22:18 [PATCH v3 0/5] Add --format to tag verification santiago
` (2 preceding siblings ...)
2016-09-30 22:18 ` [PATCH v3 3/5] tag: add format specifier to gpg_verify_tag santiago
@ 2016-09-30 22:18 ` santiago
2016-09-30 22:18 ` [PATCH v3 5/5] builtin/tag: add --format argument for tag -v santiago
2016-09-30 23:28 ` [PATCH v3 0/5] Add --format to tag verification Junio C Hamano
5 siblings, 0 replies; 11+ messages in thread
From: santiago @ 2016-09-30 22:18 UTC (permalink / raw)
To: git; +Cc: gitster, peff, sunshine, walters, Santiago Torres
From: Santiago Torres <santiago@nyu.edu>
Callers of verify-tag may want to cross-check the tagname from refs/tags
with the tagname from the tag object header upon GPG verification. This
is to avoid tag refs that point to an incorrect object.
Add a --format parameter to git verify-tag to print the formatted tag
object header in addition to or instead of the --verbose or --raw GPG
verification output.
Signed-off-by: Santiago Torres <santiago@nyu.edu>
---
Documentation/git-verify-tag.txt | 2 +-
builtin/verify-tag.c | 13 +++++++++++--
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-verify-tag.txt b/Documentation/git-verify-tag.txt
index d590edc..0b8075d 100644
--- a/Documentation/git-verify-tag.txt
+++ b/Documentation/git-verify-tag.txt
@@ -8,7 +8,7 @@ git-verify-tag - Check the GPG signature of tags
SYNOPSIS
--------
[verse]
-'git verify-tag' <tag>...
+'git verify-tag' [--format=<format>] <tag>...
DESCRIPTION
-----------
diff --git a/builtin/verify-tag.c b/builtin/verify-tag.c
index de10198..745b6a6 100644
--- a/builtin/verify-tag.c
+++ b/builtin/verify-tag.c
@@ -12,12 +12,14 @@
#include <signal.h>
#include "parse-options.h"
#include "gpg-interface.h"
+#include "ref-filter.h"
static const char * const verify_tag_usage[] = {
- N_("git verify-tag [-v | --verbose] <tag>..."),
+ N_("git verify-tag [-v | --verbose] [--format=<format>] <tag>..."),
NULL
};
+
static int git_verify_tag_config(const char *var, const char *value, void *cb)
{
int status = git_gpg_config(var, value, cb);
@@ -30,9 +32,11 @@ int cmd_verify_tag(int argc, const char **argv, const char *prefix)
{
int i = 1, verbose = 0, had_error = 0;
unsigned flags = 0;
+ char *fmt_pretty;
const struct option verify_tag_options[] = {
OPT__VERBOSE(&verbose, N_("print tag contents")),
OPT_BIT(0, "raw", &flags, N_("print raw gpg status output"), GPG_VERIFY_RAW),
+ OPT_STRING( 0 , "format", &fmt_pretty, N_("format"), N_("format to use for the output")),
OPT_END()
};
@@ -46,12 +50,17 @@ int cmd_verify_tag(int argc, const char **argv, const char *prefix)
if (verbose)
flags |= GPG_VERIFY_VERBOSE;
+ if (fmt_pretty) {
+ verify_ref_format(fmt_pretty);
+ flags |= GPG_VERIFY_QUIET;
+ }
+
while (i < argc) {
unsigned char sha1[20];
const char *name = argv[i++];
if (get_sha1(name, sha1))
had_error = !!error("tag '%s' not found.", name);
- else if (verify_and_format_tag(sha1, name, NULL, flags))
+ else if (verify_and_format_tag(sha1, name, fmt_pretty, flags))
had_error = 1;
}
return had_error;
--
2.10.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 5/5] builtin/tag: add --format argument for tag -v
2016-09-30 22:18 [PATCH v3 0/5] Add --format to tag verification santiago
` (3 preceding siblings ...)
2016-09-30 22:18 ` [PATCH v3 4/5] builtin/verify-tag: add --format to verify-tag santiago
@ 2016-09-30 22:18 ` santiago
2016-09-30 23:28 ` [PATCH v3 0/5] Add --format to tag verification Junio C Hamano
5 siblings, 0 replies; 11+ messages in thread
From: santiago @ 2016-09-30 22:18 UTC (permalink / raw)
To: git; +Cc: gitster, peff, sunshine, walters, Lukas Puehringer
From: Lukas Puehringer <luk.puehringer@gmail.com>
Adding --format to git tag -v mutes the default output of the GPG
verification and instead prints the formatted tag object.
This allows callers to cross-check the tagname from refs/tags with
the tagname from the tag object header upon GPG verification.
The callback function for for_each_tag_name() didn't allow callers to
pass custom data to their callback functions. Add a new opaque pointer
to each_tag_name_fn's parameter to allow this.
Signed-off-by: Lukas Puehringer <luk.puehringer@gmail.com>
---
Documentation/git-tag.txt | 2 +-
builtin/tag.c | 34 +++++++++++++++++++++++-----------
2 files changed, 24 insertions(+), 12 deletions(-)
diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt
index 7ecca8e..3bb5e3c 100644
--- a/Documentation/git-tag.txt
+++ b/Documentation/git-tag.txt
@@ -15,7 +15,7 @@ SYNOPSIS
'git tag' [-n[<num>]] -l [--contains <commit>] [--points-at <object>]
[--column[=<options>] | --no-column] [--create-reflog] [--sort=<key>]
[--format=<format>] [--[no-]merged [<commit>]] [<pattern>...]
-'git tag' -v <tagname>...
+'git tag' -v [--format=<format>] <tagname>...
DESCRIPTION
-----------
diff --git a/builtin/tag.c b/builtin/tag.c
index 14f3b48..7730fd0 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -24,7 +24,7 @@ static const char * const git_tag_usage[] = {
N_("git tag -d <tagname>..."),
N_("git tag -l [-n[<num>]] [--contains <commit>] [--points-at <object>]"
"\n\t\t[--format=<format>] [--[no-]merged [<commit>]] [<pattern>...]"),
- N_("git tag -v <tagname>..."),
+ N_("git tag -v [--format=<format>] <tagname>..."),
NULL
};
@@ -66,15 +66,17 @@ static int list_tags(struct ref_filter *filter, struct ref_sorting *sorting, con
}
typedef int (*each_tag_name_fn)(const char *name, const char *ref,
- const unsigned char *sha1);
+ const unsigned char *sha1, void *cb_data);
-static int for_each_tag_name(const char **argv, each_tag_name_fn fn)
+static int for_each_tag_name(const char **argv, each_tag_name_fn fn,
+ void *cb_data)
{
const char **p;
char ref[PATH_MAX];
int had_error = 0;
unsigned char sha1[20];
+
for (p = argv; *p; p++) {
if (snprintf(ref, sizeof(ref), "refs/tags/%s", *p)
>= sizeof(ref)) {
@@ -87,14 +89,14 @@ static int for_each_tag_name(const char **argv, each_tag_name_fn fn)
had_error = 1;
continue;
}
- if (fn(*p, ref, sha1))
+ if (fn(*p, ref, sha1, cb_data))
had_error = 1;
}
return had_error;
}
static int delete_tag(const char *name, const char *ref,
- const unsigned char *sha1)
+ const unsigned char *sha1, void *cb_data)
{
if (delete_ref(ref, sha1, 0))
return 1;
@@ -103,9 +105,16 @@ static int delete_tag(const char *name, const char *ref,
}
static int verify_tag(const char *name, const char *ref,
- const unsigned char *sha1)
+ const unsigned char *sha1, void *cb_data)
{
- return verify_and_format_tag(sha1, name, NULL, GPG_VERIFY_VERBOSE);
+ int flags;
+ char *fmt_pretty = cb_data;
+ flags = GPG_VERIFY_VERBOSE;
+
+ if (fmt_pretty)
+ flags = GPG_VERIFY_QUIET;
+
+ return verify_and_format_tag(sha1, name, fmt_pretty, flags);
}
static int do_sign(struct strbuf *buffer)
@@ -334,7 +343,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
struct strbuf err = STRBUF_INIT;
struct ref_filter filter;
static struct ref_sorting *sorting = NULL, **sorting_tail = &sorting;
- const char *format = NULL;
+ char *format = NULL;
struct option options[] = {
OPT_CMDMODE('l', "list", &cmdmode, N_("list tag names"), 'l'),
{ OPTION_INTEGER, 'n', NULL, &filter.lines, N_("n"),
@@ -424,9 +433,12 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
if (filter.merge_commit)
die(_("--merged and --no-merged option are only allowed with -l"));
if (cmdmode == 'd')
- return for_each_tag_name(argv, delete_tag);
- if (cmdmode == 'v')
- return for_each_tag_name(argv, verify_tag);
+ return for_each_tag_name(argv, delete_tag, NULL);
+ if (cmdmode == 'v') {
+ if (format)
+ verify_ref_format(format);
+ return for_each_tag_name(argv, verify_tag, format);
+ }
if (msg.given || msgfile) {
if (msg.given && msgfile)
--
2.10.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3 2/5] ref-filter: add function to print single ref_array_item
2016-09-30 22:18 ` [PATCH v3 2/5] ref-filter: add function to print single ref_array_item santiago
@ 2016-09-30 23:12 ` Jakub Narębski
2016-10-01 1:33 ` Junio C Hamano
0 siblings, 1 reply; 11+ messages in thread
From: Jakub Narębski @ 2016-09-30 23:12 UTC (permalink / raw)
To: Santiago Torres, git
Cc: Junio C Hamano, Jeff King, sunshine, walters, Lukas Puehringer
W dniu 01.10.2016 o 00:18, santiago@nyu.edu pisze:
> From: Lukas Puehringer <luk.puehringer@gmail.com>
>
> ref-filter functions are useful for printing git object information
> using a format specifier. However, some other modules may not want to use
> this functionality on a ref-array but only print a single item.
>
> Expose a format_ref function to create, pretty print and free individual
> ref-items.
It's now pretty_print_ref, not format_ref (old version in commit message).
[...]
> +void pretty_print_ref(const char *name, const unsigned char *sha1,
> + const char *format, unsigned kind)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/5] Add --format to tag verification
2016-09-30 22:18 [PATCH v3 0/5] Add --format to tag verification santiago
` (4 preceding siblings ...)
2016-09-30 22:18 ` [PATCH v3 5/5] builtin/tag: add --format argument for tag -v santiago
@ 2016-09-30 23:28 ` Junio C Hamano
2016-10-03 14:49 ` Santiago Torres
5 siblings, 1 reply; 11+ messages in thread
From: Junio C Hamano @ 2016-09-30 23:28 UTC (permalink / raw)
To: santiago; +Cc: git, peff, sunshine, walters
What is in the patch series looked more or less good to me. Lukas's
sirname was still P in [3/5], a patch in [4/5] added an unnecssary
blank line before git_verify_tag_config() and also a local variable
declaration for "char *fmt_pretty" was indented funnily, but none of
these were something I couldn't fix up locally.
I however notice that there is no new tests to protect these two new
features from future breakages. Perhaps you want to add some in
[6/5]?
Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 2/5] ref-filter: add function to print single ref_array_item
2016-09-30 23:12 ` Jakub Narębski
@ 2016-10-01 1:33 ` Junio C Hamano
0 siblings, 0 replies; 11+ messages in thread
From: Junio C Hamano @ 2016-10-01 1:33 UTC (permalink / raw)
To: Jakub Narębski
Cc: Santiago Torres, git, Jeff King, sunshine, walters,
Lukas Puehringer
Jakub Narębski <jnareb@gmail.com> writes:
>> Expose a format_ref function to create, pretty print and free individual
>> ref-items.
>
> It's now pretty_print_ref, not format_ref (old version in commit message).
Good eyes. Will tweak locally.
Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/5] Add --format to tag verification
2016-09-30 23:28 ` [PATCH v3 0/5] Add --format to tag verification Junio C Hamano
@ 2016-10-03 14:49 ` Santiago Torres
2016-10-03 20:58 ` Junio C Hamano
0 siblings, 1 reply; 11+ messages in thread
From: Santiago Torres @ 2016-10-03 14:49 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, peff, sunshine, walters
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
Hi, Junio.
> I however notice that there is no new tests to protect these two new
> features from future breakages. Perhaps you want to add some in
> [6/5]?
I'll be working on this. I spent some time looking around for example
tests for format. Are there any that I should pay special attention to?
(I'm looking at t7004 mostly right now).
Thanks!
-Santiago.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/5] Add --format to tag verification
2016-10-03 14:49 ` Santiago Torres
@ 2016-10-03 20:58 ` Junio C Hamano
0 siblings, 0 replies; 11+ messages in thread
From: Junio C Hamano @ 2016-10-03 20:58 UTC (permalink / raw)
To: Santiago Torres; +Cc: git, peff, sunshine, walters
Santiago Torres <santiago@nyu.edu> writes:
> Hi, Junio.
>> I however notice that there is no new tests to protect these two new
>> features from future breakages. Perhaps you want to add some in
>> [6/5]?
>
> I'll be working on this. I spent some time looking around for example
> tests for format. Are there any that I should pay special attention to?
> (I'm looking at t7004 mostly right now).
By the way, running t7030 seems to reveal a segfault introduced by
this 5-patch series.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-10-03 20:59 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-30 22:18 [PATCH v3 0/5] Add --format to tag verification santiago
2016-09-30 22:18 ` [PATCH v3 1/5] gpg-interface, tag: add GPG_VERIFY_QUIET flag santiago
2016-09-30 22:18 ` [PATCH v3 2/5] ref-filter: add function to print single ref_array_item santiago
2016-09-30 23:12 ` Jakub Narębski
2016-10-01 1:33 ` Junio C Hamano
2016-09-30 22:18 ` [PATCH v3 3/5] tag: add format specifier to gpg_verify_tag santiago
2016-09-30 22:18 ` [PATCH v3 4/5] builtin/verify-tag: add --format to verify-tag santiago
2016-09-30 22:18 ` [PATCH v3 5/5] builtin/tag: add --format argument for tag -v santiago
2016-09-30 23:28 ` [PATCH v3 0/5] Add --format to tag verification Junio C Hamano
2016-10-03 14:49 ` Santiago Torres
2016-10-03 20:58 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).