From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>,
Kevin Willford <kewillf@microsoft.com>,
Xiaolong Ye <xiaolong.ye@intel.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH 2/3] diff_flush_patch_id: stop returning error result
Date: Thu, 8 Sep 2016 03:20:29 -0400 [thread overview]
Message-ID: <20160908072029.rwsa5b6zgwwe37ly@sigill.intra.peff.net> (raw)
In-Reply-To: <5c4276ad-19ed-1481-41cf-3d506ef9c7c6@ramsayjones.plus.com>
On Thu, Sep 08, 2016 at 01:51:05AM +0100, Ramsay Jones wrote:
>
>
> On 07/09/16 23:04, Jeff King wrote:
> > All of our errors come from diff_get_patch_id(), which has
> > exactly three error conditions. The first is an internal
> > assertion, which should be a die("BUG") in the first place.
> >
> > The other two are caused by an inability to two diff blobs,
> ^^^^^^^^^^^^^^^^^
> Huh? ... to diff two blobs?
Sorry. English my getting worse be to seems.
Will fix in a re-roll.
-Peff
next prev parent reply other threads:[~2016-09-08 7:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 7:53 [RFC/PATCH 0/2] more patch-id speedups Jeff King
2016-09-07 7:54 ` [PATCH 1/2] patch-ids: turn off rename detection Jeff King
2016-09-07 12:53 ` Johannes Schindelin
2016-09-07 7:54 ` [PATCH 2/2] patch-ids: skip merge commits Jeff King
2016-09-07 12:52 ` Johannes Schindelin
2016-09-07 18:46 ` Jeff King
2016-09-07 22:08 ` Jeff King
2016-09-07 13:06 ` [RFC/PATCH 0/2] more patch-id speedups Johannes Schindelin
2016-09-07 18:49 ` Jeff King
2016-09-07 22:01 ` [RFC/PATCH v2 0/3] patch-id for merges Jeff King
2016-09-07 22:02 ` [PATCH 1/3] patch-ids: turn off rename detection Jeff King
2016-09-07 22:12 ` Jacob Keller
2016-09-07 22:04 ` [PATCH 2/3] diff_flush_patch_id: stop returning error result Jeff King
2016-09-08 0:51 ` Ramsay Jones
2016-09-08 7:20 ` Jeff King [this message]
2016-09-09 10:28 ` Johannes Schindelin
2016-09-09 10:40 ` Jeff King
2016-09-09 12:58 ` Johannes Schindelin
2016-09-09 19:37 ` Jeff King
2016-09-07 22:04 ` [PATCH 3/3] patch-ids: use commit sha1 as patch-id for merge commits Jeff King
2016-09-07 22:28 ` Jacob Keller
2016-09-07 22:38 ` Jeff King
2016-09-07 22:51 ` [RFC/PATCH v2 0/3] patch-id for merges Josh Triplett
2016-09-08 7:30 ` Jeff King
2016-09-09 20:34 ` [PATCH v3 0/2] " Jeff King
2016-09-09 20:34 ` [PATCH v3 1/2] patch-ids: turn off rename detection Jeff King
2016-09-09 20:34 ` [PATCH v3 2/2] patch-ids: define patch-id of merge commits as "null" Jeff King
2016-09-09 20:37 ` Jeff King
2016-09-09 21:13 ` Junio C Hamano
2016-09-09 21:01 ` [PATCH v3 0/2] patch-id for merges Junio C Hamano
2016-09-12 15:59 ` Jeff King
2016-09-12 17:18 ` Junio C Hamano
2016-09-12 17:56 ` Jeff King
2016-09-12 20:44 ` Junio C Hamano
2016-09-25 18:25 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908072029.rwsa5b6zgwwe37ly@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=josh@joshtriplett.org \
--cc=kewillf@microsoft.com \
--cc=mhagger@alum.mit.edu \
--cc=ramsay@ramsayjones.plus.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).