From: Jeff King <peff@peff.net>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] format-patch: Add a config option format.from to set the default for --from
Date: Mon, 1 Aug 2016 13:30:54 -0400 [thread overview]
Message-ID: <20160801173053.3ggwr6vnyywl3l4h@sigill.intra.peff.net> (raw)
In-Reply-To: <20160730181246.4aifnvqfeenddzdl@x>
On Sat, Jul 30, 2016 at 11:12:46AM -0700, Josh Triplett wrote:
> > These tests follow a different style from the "--from" tests later in
> > the script (and your second patch does follow it, and puts its test
> > close there). Any reason not to have all of the "from" tests together,
> > and using the same style?
>
> The tests covered different things. The later --from tests made sure
> that --from behaved as expected. These tests made sure that format.from
> and --from/--no-from interacted in the expected way, with the
> command-line options overriding the configuration. So, I put them next
> to the tests for other options like format.to and format.cc, which
> tested the same thing (overriding those with --no-to, --no-cc, etc).
OK. I would have grouped by "things that influence this area of
behavior", not by "config versus command-line". But I don't think either
is wrong or right. And since you are the one writing the patch, "how I
would have done it" is not a compelling review comment.
-Peff
next prev parent reply other threads:[~2016-08-01 17:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.8678faa71de50c8e78760b0bcb3d15ebeda207d5.1469871675.git-series.josh@joshtriplett.org>
2016-07-30 9:41 ` [PATCH 1/2] format-patch: Add a config option format.from to set the default for --from Josh Triplett
2016-07-30 15:40 ` Jeff King
2016-07-30 18:12 ` Josh Triplett
2016-07-30 19:11 ` [PATCH v2 0/2] format-patch: Transition the default to --from to avoid spoofed mails Josh Triplett
2016-08-01 17:47 ` Jeff King
2016-08-01 19:58 ` Josh Triplett
2016-08-01 17:30 ` Jeff King [this message]
2016-08-01 20:32 ` [PATCH 1/2] format-patch: Add a config option format.from to set the default for --from Junio C Hamano
2016-08-08 4:52 ` Josh Triplett
2016-07-30 9:42 ` [PATCH 2/2] format-patch: Default to --from Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801173053.3ggwr6vnyywl3l4h@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=josh@joshtriplett.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).