From: Josh Triplett <josh@joshtriplett.org>
To: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: [PATCH v2 0/2] format-patch: Transition the default to --from to avoid spoofed mails
Date: Sat, 30 Jul 2016 12:11:05 -0700 [thread overview]
Message-ID: <20160730191104.2ps5k7eji7aqgufg@x> (raw)
In-Reply-To: <20160730181246.4aifnvqfeenddzdl@x>
As discussed, this patch series allows transitioning the default
behavior of format-patch to --from, to avoid spoofing mails when
formatting commits not written by the user.
The first patch introduces the format.from option to set the default
value of format-patch --from. This patch doesn't change the default
behavior of format-patch, so it can go in without any transition.
The second patch changes the default to --from. If you'd like to delay
this patch for a release and mention the planned change in the release
notes, let me know and I'll provide text for the release notes; if you
don't think this needs a transition period, you can go ahead and apply
the second patch.
v2: Unify the various places setting from into a single helper function.
Josh Triplett (2):
format-patch: Add a config option format.from to set the default for --from
format-patch: Default to --from
Documentation/config.txt | 10 ++++-
builtin/log.c | 47 +++++++++++++++----
contrib/completion/git-completion.bash | 1 +-
t/t4014-format-patch.sh | 68 +++++++++++++++++++++++++--
4 files changed, 114 insertions(+), 12 deletions(-)
--
git-series 0.8.7
next prev parent reply other threads:[~2016-07-30 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.8678faa71de50c8e78760b0bcb3d15ebeda207d5.1469871675.git-series.josh@joshtriplett.org>
2016-07-30 9:41 ` [PATCH 1/2] format-patch: Add a config option format.from to set the default for --from Josh Triplett
2016-07-30 15:40 ` Jeff King
2016-07-30 18:12 ` Josh Triplett
2016-07-30 19:11 ` Josh Triplett [this message]
2016-08-01 17:47 ` [PATCH v2 0/2] format-patch: Transition the default to --from to avoid spoofed mails Jeff King
2016-08-01 19:58 ` Josh Triplett
2016-08-01 17:30 ` [PATCH 1/2] format-patch: Add a config option format.from to set the default for --from Jeff King
2016-08-01 20:32 ` Junio C Hamano
2016-08-08 4:52 ` Josh Triplett
2016-07-30 9:42 ` [PATCH 2/2] format-patch: Default to --from Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160730191104.2ps5k7eji7aqgufg@x \
--to=josh@joshtriplett.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).