From: Josh Triplett <josh@joshtriplett.org>
To: Eric Wong <e@80x24.org>
Cc: Christian Couder <christian.couder@gmail.com>,
Richard Ipsum <richard.ipsum@codethink.co.uk>,
git@vger.kernel.org, linux-kernel@vger.kernel.org,
dborowitz@google.com, Omar Jarjur <ojarjur@google.com>,
Harry Lawrence <hazbo@gmx.com>
Subject: Re: [ANNOUNCE] git-series: track changes to a patch series over time
Date: Mon, 1 Aug 2016 01:59:29 -0700 [thread overview]
Message-ID: <20160801085928.lw3ltdksyrjujutu@x> (raw)
In-Reply-To: <20160801075554.GA22222@starla>
On Mon, Aug 01, 2016 at 07:55:54AM +0000, Eric Wong wrote:
> Christian Couder <christian.couder@gmail.com> wrote:
> > On Fri, Jul 29, 2016 at 12:10 PM, Richard Ipsum
> > <richard.ipsum@codethink.co.uk> wrote:
> > > On Thu, Jul 28, 2016 at 11:40:55PM -0700, Josh Triplett wrote:
> > > [snip]
> > >>
> > >> I'd welcome any feedback, whether on the interface and workflow, the
> > >> internals and collaboration, ideas on presenting diffs of patch series,
> > >> or anything else.
>
> > > I'm particularly interested in trying to establish a standard for
> > > storing review data in git. I've got a prototype for doing that[3],
> > > and an example tool that uses it[4]. The tool is still incomplete/buggy though.
> >
> > There is also git-appraise (https://github.com/google/git-appraise)
> > written in Go to store code review data in Git.
> > It looks like it stores its data in git notes and can be integrated
> > with Rust (https://github.com/Nemo157/git-appraise-rs).
>
> I'm not convinced another format/standard is needed besides the
> email workflow we already use for git and kernel development.
Not all projects use a patches-by-email workflow, or want to. To the
extent that tools and projects use some other workflow, standardizing
the format they use to store patch reviews (including per-line
annotations, approvals, test results, etc) seems preferable to having
each tool use its own custom format.
> I also see the reliance on an after-the-fact search engine
> (which can be tuned/replaced) as philosophically inline with
> what git does, too, such as not having rename tracking and
> doing delayed deltafication.
Storing review data in git doesn't mean it needs to end up in the
history of the project itself; it can use after-the-fact annotations on
a commit.
> Email also has the advantage of having existing tooling, and
> being (at least for now) federated without a single point of
> failure.
Storing review data in git makes it easy to push and pull it, which can
provide the basis for a federated system.
- Josh Triplett
next prev parent reply other threads:[~2016-08-01 8:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 6:40 [ANNOUNCE] git-series: track changes to a patch series over time Josh Triplett
2016-07-29 10:10 ` Richard Ipsum
2016-07-29 11:04 ` Josh Triplett
2016-07-29 12:44 ` Richard Ipsum
2016-07-29 13:00 ` Josh Triplett
2016-07-31 14:35 ` Richard Ipsum
2016-07-29 16:59 ` Stefan Beller
2016-07-31 14:09 ` Richard Ipsum
2016-08-01 5:04 ` Christian Couder
2016-08-01 7:55 ` Eric Wong
2016-08-01 8:59 ` Josh Triplett [this message]
2016-08-01 9:53 ` Richard Ipsum
2016-08-01 21:19 ` Eric Wong
2016-08-01 15:14 ` Stephen Warren
2016-08-01 18:37 ` Josh Triplett
2016-08-15 18:17 ` Simon Glass
2016-08-15 20:05 ` Josh Triplett
2016-08-03 19:12 ` Richard Ipsum
2016-08-04 22:40 ` Josh Triplett
2016-08-10 9:37 ` Richard Ipsum
2016-08-10 22:07 ` Josh Triplett
2016-08-11 6:23 ` Eric Wong
2016-08-24 10:56 ` Jakub Narębski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801085928.lw3ltdksyrjujutu@x \
--to=josh@joshtriplett.org \
--cc=christian.couder@gmail.com \
--cc=dborowitz@google.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=hazbo@gmx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojarjur@google.com \
--cc=richard.ipsum@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).