From: Josh Triplett <josh@joshtriplett.org>
To: Richard Ipsum <richard.ipsum@codethink.co.uk>
Cc: git@vger.kernel.org, linux-kernel@vger.kernel.org, dborowitz@google.com
Subject: Re: [ANNOUNCE] git-series: track changes to a patch series over time
Date: Fri, 29 Jul 2016 06:00:55 -0700 [thread overview]
Message-ID: <20160729130054.GD4340@x> (raw)
In-Reply-To: <20160729124443.GA3686@salo>
On Fri, Jul 29, 2016 at 01:44:44PM +0100, Richard Ipsum wrote:
> On Fri, Jul 29, 2016 at 04:04:26AM -0700, Josh Triplett wrote:
> > I hope to use git notes with git-series in the future, by putting
> > another gitlink under the git-series for notes related to the series.
> > I'd intended that for more persistent notes; putting them in the series
> > solves some of the problems related to notes refs, pushing/pulling, and
> > collaboration. Using notes for review comments makes sense as well,
> > whether in a series or in a separate ref.
>
> Sounds interesting, can you explain how this works in more detail?
The tree within a git-series commit includes a blob "cover" for the
cover letter, a gitlink "base" for the base commit, and a gitlink
"series" for the top of the series. I could add a gitlink "notes",
which acts like a notes ref; then, each version of the series would have
its own notes ref. As with the series, git-series would track the
"history of history"; since git-notes themselves use git history to
store a set of notes, git-series would store the history of the notes.
So if you add, remove, or change a note, git-series would track that as
a change to the notes ref. If you merge/rebase/etc the notes ref to
merge notes, git-series would track that too. A different series would
have a different set of notes, so you wouldn't be limited to
one notes ref per repository.
This doesn't solve the problem of merging notes, but it *does* mean you
have a full history of the changes to notes, not just the notes
themselves.
Something similar might work for the Gerrit notesdb.
> > > I've been considering taking the perl-notedb prototype and writing
> > > a C library for it with bindings for other languages (i.e. Rust).
> >
> > A C library based on libgit2 seems like a good idea; ideally the
> > bindings could interoperate with git2-rs. (Alternatively, Rust can
> > *export* a C interface, so you could write directly with git2-rs. :) )
>
> Certainly a fair alternative, though it may arguably be safer to write
> the C and export to other languages, as cool as Rust looks it's not
> established the way C is, so may be a slightly riskier foundation,
> in my view.
I was mostly joking there. Rust makes that potentially reasonable,
unlike most languages that can consume but not easily provide a C API,
but that doesn't make it the ideal solution quite yet. :)
> And ofcourse in C we have native access to libgit2.
Right.
> > One of the items on my long-term TODO list is a completely federated
> > GitHub; I've been looking at other aspects of that, but federated
> > reviews/comments/etc seem critical to that as well.
>
> I agree.
next prev parent reply other threads:[~2016-07-29 13:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 6:40 [ANNOUNCE] git-series: track changes to a patch series over time Josh Triplett
2016-07-29 10:10 ` Richard Ipsum
2016-07-29 11:04 ` Josh Triplett
2016-07-29 12:44 ` Richard Ipsum
2016-07-29 13:00 ` Josh Triplett [this message]
2016-07-31 14:35 ` Richard Ipsum
2016-07-29 16:59 ` Stefan Beller
2016-07-31 14:09 ` Richard Ipsum
2016-08-01 5:04 ` Christian Couder
2016-08-01 7:55 ` Eric Wong
2016-08-01 8:59 ` Josh Triplett
2016-08-01 9:53 ` Richard Ipsum
2016-08-01 21:19 ` Eric Wong
2016-08-01 15:14 ` Stephen Warren
2016-08-01 18:37 ` Josh Triplett
2016-08-15 18:17 ` Simon Glass
2016-08-15 20:05 ` Josh Triplett
2016-08-03 19:12 ` Richard Ipsum
2016-08-04 22:40 ` Josh Triplett
2016-08-10 9:37 ` Richard Ipsum
2016-08-10 22:07 ` Josh Triplett
2016-08-11 6:23 ` Eric Wong
2016-08-24 10:56 ` Jakub Narębski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729130054.GD4340@x \
--to=josh@joshtriplett.org \
--cc=dborowitz@google.com \
--cc=git@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.ipsum@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).