From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
norm@dad.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>,
l.s.r@web.de, git@vger.kernel.org
Subject: Re: [PATCH] pager: disable color when pager is "more"
Date: Tue, 19 Jul 2016 02:37:46 +0000 [thread overview]
Message-ID: <20160719023746.GA3420@plume> (raw)
In-Reply-To: <xmqq8twylv8y.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
> > On Mon, Jul 18, 2016 at 09:19:07AM +0000, Eric Wong wrote:
> >> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> >> > On Sun, 17 Jul 2016, norm@dad.org wrote:
> >> > > 'git diff' outputs escape characters which clutter my terminal. Yes, I
> >> > > can sed them out, but then why are they there?
> >> >
> >> > Those are most likely the ANSI sequences to add color. Can you call Git
> >> > with the --no-color option and see whether the escape characters go away?
> >>
> >> Norm: do you have PAGER=more set by any chance?
> >> Perhaps changing it to "less" will allow you to preserve colors.
> >>
> >> I saw a similar or identical problem during my vacation in
> >> FreeBSD-land. Perhaps the out-of-the-box experience can be
> >> improved:
> >>
> >> -----8<-----
> >> Subject: [PATCH] pager: disable color when pager is "more"
> >
> > This is the tip of a smaller iceberg. See
> >
> > http://public-inbox.org/git/52D87A79.6060600%40rawbw.com/t/#u
> >
> > for more discussion, and some patches that fix more cases (like "LESS"
> > without "R", or "more" that _does_ understand "R"). I think it was
> > discarded as being a little too intimate with the details of pagers, but
> > it does suck that the out-of-the-box experience on FreeBSD is not good.
> > Maybe we should revisit it.
Yes; I'd prefer not to get too intimate with the details of
pagers, either, and I think we should err on the side of
monochrome for systems we do not know much about.
> Yup, the three-patch series at
>
> http://public-inbox.org/git/20140117041430.GB19551%40sigill.intra.peff.net/
I am not a fan of adding #ifdefs for platform-specific things;
so I prefer starting with my original patch to disable colors
for "more". (or, even disable colors for everything which
is not "less" or "lv")
> would be a safe starting point that is low-impact. I think what
> ended up being discarded was a more elaborate side topic that
> started from exploring the possibility of checking if LESS has 'R'
> in it to see if it is possible to help people with LESS that does
> not allow coloring explicitly exported.
Heh... (see below)
> I do not think the approach in the same thread suggested by Kyle
>
> http://public-inbox.org/git/62DB6DEF-8B39-4481-BA06-245BF45233E5%40gmail.com/
>
> is too bad, either.
I like Kyle's suggestion, and I think that can be a good
transition from your original patch to move pager
configuration into the build:
https://public-inbox.org/git/xmqq61piw4yf.fsf@gitster.dls.corp.google.com/
I've updated just that and pushed just that to the "pager-build"
topic of git://bogomips.org/git-svn
So I'd prefer we drop the later automatic header generation
changes that got squashed into later iterations.
Unfortunately, it looks like that all got lost in Jeff's
13-patch "makefile refactoring" topic starting at:
https://public-inbox.org/git/20140205174823.GA15070@sigill.intra.peff.net/
Yeah, we tend to get sidetracked :x
prev parent reply other threads:[~2016-07-19 2:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 19:12 Question: Getting 'git diff' to generate /usr/bin/diff output norm
2016-07-16 20:47 ` Perry Hutchison
2016-07-17 7:46 ` Johannes Schindelin
2016-07-19 15:20 ` norm
2016-07-17 12:18 ` René Scharfe
2016-07-17 17:26 ` norm
2016-07-18 7:23 ` Johannes Schindelin
2016-07-18 9:19 ` [PATCH] pager: disable color when pager is "more" Eric Wong
2016-07-18 13:16 ` Jeff King
2016-07-18 17:19 ` Junio C Hamano
2016-07-18 18:58 ` Jeff King
2016-07-19 2:37 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719023746.GA3420@plume \
--to=e@80x24.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=norm@dad.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).